From: Mark Brown <broonie@kernel.org>
To: ChiYuan Huang <u0084500@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
cy_huang <cy_huang@richtek.com>,
gene_chen@richtek.com, lkml <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759 DCDC converter
Date: Sat, 26 Mar 2022 01:07:45 +0000 [thread overview]
Message-ID: <Yj5nYUeizlmlbX4O@sirena.org.uk> (raw)
In-Reply-To: <CADiBU3-3QLi5PVUymk_VCbF+-uVSqjoP9jLGL+R=PQ-S=Y=_AA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Sat, Mar 26, 2022 at 08:58:47AM +0800, ChiYuan Huang wrote:
> I tried to remove only __maybe_unused and build with x86 config that
> CONFIG_OF=n.
> There's no warning or error message when compiling the rt5759 source code.
> If so, I will remove only '__maybe_unused'.
> May I ask whether 'of_match_ptr' need to be added or not?
If you add of_match_ptr() (which is a little better, though it's
a tiny different either way) then you shouldn't remove
__maybe_unused - the thing here is that the __maybe_unused is
needed because of_match_ptr() is used.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-26 1:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 1:06 [PATCH 0/2] Add Richtek RT5759 buck converter support cy_huang
2022-03-25 1:06 ` [PATCH 1/2] dt-bindings: regulator: Add binding for Richtek RT5759 DCDC converter cy_huang
2022-03-25 12:14 ` Krzysztof Kozlowski
2022-03-25 13:44 ` ChiYuan Huang
2022-03-25 14:46 ` Krzysztof Kozlowski
2022-03-25 14:53 ` ChiYuan Huang
2022-03-25 1:06 ` [PATCH 2/2] regulator: rt5759: Add support " cy_huang
2022-03-25 12:17 ` Krzysztof Kozlowski
2022-03-25 14:10 ` ChiYuan Huang
2022-03-25 14:47 ` Krzysztof Kozlowski
2022-03-25 14:59 ` ChiYuan Huang
2022-03-25 15:37 ` Krzysztof Kozlowski
2022-03-25 15:50 ` ChiYuan Huang
2022-03-25 15:55 ` Krzysztof Kozlowski
2022-03-25 16:05 ` Mark Brown
2022-03-25 16:08 ` Krzysztof Kozlowski
2022-03-26 0:58 ` ChiYuan Huang
2022-03-26 1:07 ` Mark Brown [this message]
2022-03-26 7:55 ` ChiYuan Huang
2022-03-26 8:13 ` Krzysztof Kozlowski
2022-03-26 8:24 ` ChiYuan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj5nYUeizlmlbX4O@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®