From: Petr Mladek <pmladek@suse.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Yafang Shao <laoar.shao@gmail.com>,
Cai Huoqing <caihuoqing@baidu.com>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/kthread.h: remove unused macros
Date: Tue, 15 Mar 2022 10:18:20 +0100 [thread overview]
Message-ID: <YjBZ3Ir3H7IM9Pfj@alley> (raw)
In-Reply-To: <20220314145343.494694-1-linux@rasmusvillemoes.dk>
On Mon 2022-03-14 15:53:42, Rasmus Villemoes wrote:
> Ever since these macros were introduced in commit b56c0d8937e6
> ("kthread: implement kthread_worker"), there has been precisely one
> user (commit 4d115420707a, "NVMe: Async IO queue deletion"), and that
> user went away in 2016 with db3cbfff5bcc ("NVMe: IO queue deletion
> re-write").
>
> Apart from being unused, these macros are also awkward to use (which
> may contribute to them not being used): Having a way to statically (or
> on-stack) allocating the storage for the struct kthread_worker itself
> doesn't help much, since obviously one needs to have some code for
> actually _spawning_ the worker thread, which must have error
> checking. And these days we have the kthread_create_worker() interface
> which both allocates the struct kthread_worker and spawns the kthread.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Makes sense.
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
prev parent reply other threads:[~2022-03-15 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 14:53 Rasmus Villemoes
2022-03-14 16:02 ` Tejun Heo
2022-03-15 9:18 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjBZ3Ir3H7IM9Pfj@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=caihuoqing@baidu.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®