From: Greg KH <gregkh@linuxfoundation.org>
To: Charlie Sands <sandsch@northvilleschools.net>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.
Date: Tue, 15 Mar 2022 15:20:07 +0100 [thread overview]
Message-ID: <YjCglwPG1rJFp1/x@kroah.com> (raw)
In-Reply-To: <Yi/5nEXVmzZrbfbz@sckzor-linux.localdomain>
On Mon, Mar 14, 2022 at 10:27:40PM -0400, Charlie Sands wrote:
> This patch remedies the following checkpath.pl issues:
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&dev->pci->dev, "%s called\n", __func__);
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&dev->pci->dev, "%s called\n", __func__);
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&pci->dev, "%s called\n", __func__);
>
> Signed-off-by: Charlie Sands <sandsch@northvilleschools.net>
> ---
> drivers/staging/rts5208/rtsx.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 5a58dac76c88..643d33b9a239 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -159,8 +159,6 @@ static int command_abort(struct scsi_cmnd *srb)
> struct rtsx_dev *dev = host_to_rtsx(host);
> struct rtsx_chip *chip = dev->chip;
>
> - dev_info(&dev->pci->dev, "%s called\n", __func__);
> -
> scsi_lock(host);
>
> /* Is this command still active? */
> @@ -188,8 +186,6 @@ static int device_reset(struct scsi_cmnd *srb)
> {
> struct rtsx_dev *dev = host_to_rtsx(srb->device->host);
>
> - dev_info(&dev->pci->dev, "%s called\n", __func__);
> -
> return SUCCESS;
> }
>
> @@ -968,8 +964,6 @@ static void rtsx_remove(struct pci_dev *pci)
> {
> struct rtsx_dev *dev = pci_get_drvdata(pci);
>
> - dev_info(&pci->dev, "%s called\n", __func__);
> -
> quiesce_and_remove_host(dev);
> release_everything(dev);
> pci_release_regions(pci);
> --
> 2.35.1
>
>
Always test-build your patches. Applying this change results in a build
failure :(
Please fix up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-15 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 2:27 Charlie Sands
2022-03-15 14:20 ` Greg KH [this message]
2022-03-15 21:15 Charlie Sands
2022-03-16 6:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjCglwPG1rJFp1/x@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sandsch@northvilleschools.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®