From: Peter Zijlstra <peterz@infradead.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Borislav Petkov <bp@alien8.de>,
Lai Jiangshan <jiangshan.ljs@antgroup.com>
Subject: Re: [PATCH V3 0/7] x86/entry: Clean up entry code
Date: Wed, 16 Mar 2022 16:13:00 +0100 [thread overview]
Message-ID: <YjH+fAaH5yHGrxRu@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YjH+VdHIiHZM3maD@hirez.programming.kicks-ass.net>
On Wed, Mar 16, 2022 at 04:12:21PM +0100, Peter Zijlstra wrote:
> On Tue, Mar 15, 2022 at 03:39:42PM +0800, Lai Jiangshan wrote:
>
> > Lai Jiangshan (7):
> > x86/entry: Use idtentry macro for entry_INT80_compat
> > x86/traps: Move pt_regs only in fixup_bad_iret()
> > x86/entry: Switch the stack after error_entry() returns
> > x86/entry: move PUSH_AND_CLEAR_REGS out of error_entry
> > x86/entry: Move cld to the start of idtentry
> > x86/entry: Don't call error_entry for XENPV
> > x86/entry: Convert SWAPGS to swapgs and remove the definition of
> > SWAPGS
>
> So AFAICT these patches are indeed correct.
>
> I do however worry a little bit about the I$ impact of patch 4, and
> there's a few niggles, but otherwise looks good.
>
> I'd love for some of the other x86 people to also look at this, but a
> tentative ACK on this.
>
Also, I forgot to mention; they no longer apply cleanly because I
sprinked ENDBR all over the place. Mostly trivial to fixup though.
next prev parent reply other threads:[~2022-03-16 15:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 7:39 Lai Jiangshan
2022-03-15 7:39 ` [PATCH V3 1/7] x86/entry: Use idtentry macro for entry_INT80_compat Lai Jiangshan
2022-03-16 13:48 ` Peter Zijlstra
2022-03-15 7:39 ` [PATCH V3 2/7] x86/traps: Move pt_regs only in fixup_bad_iret() Lai Jiangshan
2022-03-15 7:39 ` [PATCH V3 3/7] x86/entry: Switch the stack after error_entry() returns Lai Jiangshan
2022-03-16 2:37 ` Josh Poimboeuf
2022-03-16 3:02 ` Lai Jiangshan
2022-03-16 15:05 ` Peter Zijlstra
2022-03-16 16:43 ` Lai Jiangshan
2022-03-18 11:12 ` Peter Zijlstra
2022-03-15 7:39 ` [PATCH V3 4/7] x86/entry: move PUSH_AND_CLEAR_REGS out of error_entry Lai Jiangshan
2022-03-16 15:07 ` Peter Zijlstra
2022-03-16 16:18 ` Lai Jiangshan
2022-03-15 7:39 ` [PATCH V3 5/7] x86/entry: Move cld to the start of idtentry Lai Jiangshan
2022-03-15 7:39 ` [PATCH V3 6/7] x86/entry: Don't call error_entry for XENPV Lai Jiangshan
2022-03-16 2:59 ` Josh Poimboeuf
2022-03-16 15:09 ` Peter Zijlstra
2022-03-16 16:48 ` Lai Jiangshan
2022-03-15 7:39 ` [PATCH V3 7/7] x86/entry: Convert SWAPGS to swapgs and remove the definition of SWAPGS Lai Jiangshan
2022-03-16 15:12 ` [PATCH V3 0/7] x86/entry: Clean up entry code Peter Zijlstra
2022-03-16 15:13 ` Peter Zijlstra [this message]
2022-03-17 12:58 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjH+fAaH5yHGrxRu@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=jiangshan.ljs@antgroup.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®