From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ricky WU <ricky_wu@realtek.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw()
Date: Fri, 18 Mar 2022 13:53:01 +0100 [thread overview]
Message-ID: <YjSArZ10NZLsJ3vb@kroah.com> (raw)
In-Reply-To: <20220307141421.GC18867@kili>
On Mon, Mar 07, 2022 at 05:14:21PM +0300, Dan Carpenter wrote:
> This code should be indented one more tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261
> support Runtime PM"). No Fixes tag because it's not a bug.
>
> drivers/misc/cardreader/rts5228.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/cardreader/rts5228.c b/drivers/misc/cardreader/rts5228.c
> index af581f4f74d1..ec97854e1f70 100644
> --- a/drivers/misc/cardreader/rts5228.c
> +++ b/drivers/misc/cardreader/rts5228.c
> @@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
>
> if (pcr->rtd3_en) {
> rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
> - rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> - FORCE_PM_CONTROL | FORCE_PM_VALUE,
> - FORCE_PM_CONTROL | FORCE_PM_VALUE);
> + rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> + FORCE_PM_CONTROL | FORCE_PM_VALUE,
> + FORCE_PM_CONTROL | FORCE_PM_VALUE);
> } else {
> rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
> rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> --
> 2.20.1
>
Someone beat you to it:
https://lore.kernel.org/r/20220303020206.98911-1-yang.lee@linux.alibaba.com
prev parent reply other threads:[~2022-03-18 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:14 Dan Carpenter
2022-03-18 12:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjSArZ10NZLsJ3vb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricky_wu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®