From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4FFC433EF for ; Mon, 21 Mar 2022 13:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347795AbiCUNSb (ORCPT ); Mon, 21 Mar 2022 09:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234032AbiCUNS3 (ORCPT ); Mon, 21 Mar 2022 09:18:29 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E33960069; Mon, 21 Mar 2022 06:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dPqXoSF/BeSCZ7Job8RJ69pE2t1ba6D8uNorfi1dsLk=; b=djdxHbzrr4Tlwtv6Aw+XiehFc0 frFLqPoENJSnbdMDNDHmwv3EVPrtXv43OXpoNz2JkpIBLNFn+CUfGbGROeOkxKBqJovdVVoVmuYJO yhbP74jYXh8QP1a+RIXtRSOV+zxKrwNkrZ6mGNLLV4LFaPrXU/t5KCdWLfiRWmfq9v5w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nWHu6-00Bwqw-7j; Mon, 21 Mar 2022 14:16:58 +0100 Date: Mon, 21 Mar 2022 14:16:58 +0100 From: Andrew Lunn To: Robert Marko Cc: gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, Rob Herring , Linux ARM , devicetree , Linux Kernel Mailing List , Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH 1/2] arm64: dts: uDPU: update partition table Message-ID: References: <20220321121728.414839-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 01:47:21PM +0100, Robert Marko wrote: > On Mon, Mar 21, 2022 at 1:41 PM Andrew Lunn wrote: > > > > On Mon, Mar 21, 2022 at 01:17:27PM +0100, Robert Marko wrote: > > > Partition currently called "uboot" does not only contain U-boot, but > > > rather it contains TF-A, U-boot and U-boot environment. > > > > > > So, to avoid accidentally deleting the U-boot environment which is > > > located at 0x180000 split the partition. > > > > > > "uboot" is not the correct name as you can't boot these boards with U-boot > > > only, TF-A must be present as well, so rename the "uboot" partition to > > > "firmware". > > > > Are there any ABI issues here? If these names are being used > > somewhere, you are potentially breaking the boot. At minimum, i would > > like to see something in the commit message which indicates you have > > considered this and why you don't expect it to be a problem. > > Hi Andrew, this won't break booting as BootROM does not care about > partitions nor naming, it will just go to 0x0 of the NOR and boot it. > > The same renaming had already been done: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/marvell?h=v5.17&id=a9d9bfcadfb43b856dbcf9419de75f7420d5a225 > > I can update the commit message if required. Yes, please. It is always good to indicate you have thought about issues like this. Not breaking the ABI is very important, and could result in this getting reverted at some point. So indicating why you think this is safe is useful information. Andrew