From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EAA1C433FE for ; Mon, 21 Mar 2022 12:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347513AbiCUMnZ (ORCPT ); Mon, 21 Mar 2022 08:43:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347575AbiCUMnI (ORCPT ); Mon, 21 Mar 2022 08:43:08 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CA06158D85; Mon, 21 Mar 2022 05:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=/OoQA2C4opCgk8x2lj3pHFSDfpkhAccLtFf/6lMUfYQ=; b=kUtJQWixDH80LVAnhbDfBTrcEk 5nNGeNE8pXGoM/OHMTNTfAmHJVpqzwZ8JGgagpp6FHe9/rB6PPqmKNRXSOUdasQmrR1KKKvEviEhz istE8jROHTI30VltkyGXfmWKe7YFdQEPZBQl4idSxQ9WsPTD8prprEUwM5Rum/01wxp4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nWHLv-00Bwcj-4v; Mon, 21 Mar 2022 13:41:39 +0100 Date: Mon, 21 Mar 2022 13:41:39 +0100 From: Andrew Lunn To: Robert Marko Cc: gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pali@kernel.org, marek.behun@nic.cz Subject: Re: [PATCH 1/2] arm64: dts: uDPU: update partition table Message-ID: References: <20220321121728.414839-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321121728.414839-1-robert.marko@sartura.hr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 01:17:27PM +0100, Robert Marko wrote: > Partition currently called "uboot" does not only contain U-boot, but > rather it contains TF-A, U-boot and U-boot environment. > > So, to avoid accidentally deleting the U-boot environment which is > located at 0x180000 split the partition. > > "uboot" is not the correct name as you can't boot these boards with U-boot > only, TF-A must be present as well, so rename the "uboot" partition to > "firmware". Are there any ABI issues here? If these names are being used somewhere, you are potentially breaking the boot. At minimum, i would like to see something in the commit message which indicates you have considered this and why you don't expect it to be a problem. Andrew