From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA88AC433EF for ; Mon, 21 Mar 2022 12:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347555AbiCUMsC (ORCPT ); Mon, 21 Mar 2022 08:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347539AbiCUMsA (ORCPT ); Mon, 21 Mar 2022 08:48:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2512E986F0; Mon, 21 Mar 2022 05:46:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C087EB81115; Mon, 21 Mar 2022 12:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A36C340F2; Mon, 21 Mar 2022 12:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647866792; bh=BkBf+XFWCAFnCR/tIuvZqXB3Sz74SS7v8oRpDMkj3uM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJZ11NuW33i8Nzk5Pj4MfF+w79QvgPBxptvAIOI39vAFc2EZjKLDYNoQd2oVBaNiy mci7fV94a9SUIa4t2sTeyU1nbx4HI+NY7/KFd1rBTH+pQWcAOB2NOc3c0PL4IECDy6 vtHm55IA1FPfSNFNe0TcPTUm8jrYOG6AXu4UMQUw= Date: Mon, 21 Mar 2022 13:46:29 +0100 From: "gregkh@linuxfoundation.org" To: Geliang Tang Cc: "ast@kernel.org" , "linux-kernel@vger.kernel.org" , "memxor@gmail.com" , "sashal@kernel.org" , "stable@vger.kernel.org" , Guoqing Jiang , Kai Liu Subject: Re: [PATCH 5.10 37/71] selftests/bpf: Add test for bpf_timer overwriting crash Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2022 at 02:42:49PM +0000, Geliang Tang wrote: > Hi Greg, > > I got this bpf selftests build break today on the stable branch 5.10.106: > > ========================================================================= > CLNG-LLC [test_maps] test_tracepoint.o > progs/timer_crash.c:8:19: error: field has incomplete type 'struct bpf_timer' > struct bpf_timer timer; > ^ > progs/timer_crash.c:8:9: note: forward declaration of 'struct bpf_timer' > struct bpf_timer timer; > ^ > progs/timer_crash.c:35:6: warning: implicit declaration of function 'bpf_get_current_task_btf' is invalid in C99 [-Wimplicit-function-declaration] > if (bpf_get_current_task_btf()->tgid != pid) > ^ > progs/timer_crash.c:35:34: error: member reference type 'int' is not a pointer > if (bpf_get_current_task_btf()->tgid != pid) > ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > progs/timer_crash.c:49:3: warning: implicit declaration of function 'bpf_timer_cancel' is invalid in C99 [-Wimplicit-function-declaration] > bpf_timer_cancel(&e->timer); > ^ > 2 warnings and 2 errors generated. > CLNG-LLC [test_maps] test_trace_ext_tracing.o > llc: error: llc: :1:1: error: expected top-level entity > BPF obj compilation failed > ^ > make: *** [Makefile:402: tools/testing/selftests/bpf/timer_crash.o] Error 1 > make: *** Waiting for unfinished jobs.... > CLNG-LLC [test_maps] test_trace_ext.o > ========================================================================= > > It is introduced by this commit, "selftests/bpf: Add test for bpf_timer > overwriting crash". Since the commit "bpf: Introduce bpf timers." has not > been merged into the stable branch yet. > > I am writing to you to report this bug. > Now reverted, thanks! greg k-h