From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D797C433F5 for ; Wed, 6 Apr 2022 15:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236539AbiDFP4f (ORCPT ); Wed, 6 Apr 2022 11:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236819AbiDFP4V (ORCPT ); Wed, 6 Apr 2022 11:56:21 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31B25AE69C for ; Wed, 6 Apr 2022 06:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649251396; x=1680787396; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=D/2p8w7LqfpUhFjPcN1odO+2muCpehswAzNgoS39MJw=; b=Lm1soxImFAsHC9PmiZMCloU4cdO2LvyP5ac0VrpCoOO0Hdk5Sxcv4and o/okgQAJvr2i79n24OP/q37BWmU3578qJmpsHiTmCT5dwVjdK0A2+jc/j nJFQCqaNUfNzSzLkrHphsbKEzlr+5UFZ8DZXfH6mAAv7S2pGvnlNIWnNz ZA4TRCT3WDira1eV6898Jhp2ZmllvbexYRNBBQ/zvSrUKimr9Lpl+SWCO OGZkSPKh3aqnMJNttvVtO24wvQFLz+51etczq5H3m8fv5xMvRPzqgunEt rXwmhoVvOBTRpadFLi4eSaNMDfIrSkn6b1BrTkYGur6W/E+aVlJCvX7nb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="248564684" X-IronPort-AV: E=Sophos;i="5.90,239,1643702400"; d="scan'208";a="248564684" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 06:23:15 -0700 X-IronPort-AV: E=Sophos;i="5.90,239,1643702400"; d="scan'208";a="722511594" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 06:23:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nc5bS-000EVg-Am; Wed, 06 Apr 2022 16:21:42 +0300 Date: Wed, 6 Apr 2022 16:21:42 +0300 From: Andy Shevchenko To: Mark Brown Cc: Detlev Casanova , Dave Stevenson , linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment Message-ID: References: <20220325184508.45670-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2022 at 02:13:09PM +0100, Mark Brown wrote: > On Wed, Apr 06, 2022 at 04:01:41PM +0300, Andy Shevchenko wrote: > > On Fri, Mar 25, 2022 at 08:45:08PM +0200, Andy Shevchenko wrote: > > > GPIO library does copy the of_node from the parent device of > > > the GPIO chip, there is no need to repeat this in the individual > > > drivers. Remove these assignment all at once. > > > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Any comments on this? Can it be applied now? > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. Oops, indeed, it has been only 12 days passed with no nothing :-) -- With Best Regards, Andy Shevchenko