From: Christoph Hellwig <hch@infradead.org>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org,
"Christoph Böhmwalder" <christoph@boehmwalder.at>
Subject: Re: [PATCH 3/3] drbd: set QUEUE_FLAG_STABLE_WRITES
Date: Wed, 6 Apr 2022 23:15:15 -0700 [thread overview]
Message-ID: <Yk6Bc7lvjCsmlkoq@infradead.org> (raw)
In-Reply-To: <20220406190445.1937206-4-christoph.boehmwalder@linbit.com>
On Wed, Apr 06, 2022 at 09:04:45PM +0200, Christoph Böhmwalder wrote:
> From: Christoph Böhmwalder <christoph@boehmwalder.at>
>
> We want our pages not to change while they are being written.
Please document the _why_. A commit like that will leave everyone
looking at this code in the future rather puzzled.
next prev parent reply other threads:[~2022-04-07 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 19:04 [PATCH 0/3] DRBD fixes for Linux 5.18 Christoph Böhmwalder
2022-04-06 19:04 ` [PATCH 1/3] drbd: Fix five use after free bugs in get_initial_state Christoph Böhmwalder
2022-04-06 19:04 ` [PATCH 2/3] drbd: fix an invalid memory access caused by incorrect use of list iterator Christoph Böhmwalder
2022-04-06 19:04 ` [PATCH 3/3] drbd: set QUEUE_FLAG_STABLE_WRITES Christoph Böhmwalder
2022-04-07 6:15 ` Christoph Hellwig [this message]
2022-04-06 19:08 ` [PATCH 0/3] DRBD fixes for Linux 5.18 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk6Bc7lvjCsmlkoq@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=christoph@boehmwalder.at \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®