From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B9EC433FE for ; Thu, 7 Apr 2022 13:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343625AbiDGNT5 (ORCPT ); Thu, 7 Apr 2022 09:19:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244230AbiDGNTm (ORCPT ); Thu, 7 Apr 2022 09:19:42 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A9425C5AE for ; Thu, 7 Apr 2022 06:17:42 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id m16so4866577plx.3 for ; Thu, 07 Apr 2022 06:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xaFEdMdha8h42RWuuCwkqr0VCzd2sB+RNX9htkQaFF8=; b=Q4WySDtp3npUzYr7LCaMAKpcChHDjH5EtYUxBS5WjOSTpOpufANpns13Wj+Gr5G4fd 4PLyrEBAHnA8hP7wi5Fp4DWo3gcHnsvGkCyd9de+rZCEyRvhfh+9OyU43/6ViKKekO3t ACFLGS30cXfOQMNSCfPt8RKp3Z/31TLN7JJLVJHkGsuC8p+owLhPH1Jmuaowilivo7tK VJjHd2wg0+tNykHOV//TkfGAyTOj1fc/5aM8aqbyUgrgZDMQteysSqAFbFCCMB2llKt+ RIGkunul47ZCrDyTAnmjYJweTgzfRcLRQ0qiyCL6wyUIX0BAF95+9a+hsJhych8H1lSg ScGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xaFEdMdha8h42RWuuCwkqr0VCzd2sB+RNX9htkQaFF8=; b=co/vLwE4fZSAaIIG618gomKAIjxvJlRVBklZenGirytIxPsKa0qiO+RJfsrY9dTcT0 tlfAPUuv+fbneEgUWQV8w4NCcy002l6Qx9n7Oz9HbzPxEEhWuNhcCFXPpQaZAx/Djtyu jx+heM6N4WNX90htVJ/2c/15M/lFTtvt33LRuPCfDVHEfGgv3qERBs37Io9owSzi4myL V/DP95F4Zhw+Db90P6CY3PqzCEgV6Y0Wrr+MLxUzWSWUHYXgGFbanimL3kYNrhG7N3oa LMG1zVFjQOt4ptv7aWLbsniA4h9KyHAwisj+U02AGyNpRvjhtq1SDK/Q7MVu4q1M6I7j iZkA== X-Gm-Message-State: AOAM530dVI4++CGWR/CsukzBcExNNWq4gWkAgVFxZlSIU5avqaknT7ZB b06/nxeV3kxZDyMa34smL5rjpw== X-Google-Smtp-Source: ABdhPJzAIA6zaue5y4/HWCW1DduN5qnV98L+dQLWSOQjhzJalpap83t1+9GZcLK+U+u0+q/rNrvpXQ== X-Received: by 2002:a17:90b:4c12:b0:1c6:f450:729d with SMTP id na18-20020a17090b4c1200b001c6f450729dmr16146151pjb.190.1649337462055; Thu, 07 Apr 2022 06:17:42 -0700 (PDT) Received: from localhost ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id d5-20020a056a0024c500b004fae56b2921sm22997159pfv.167.2022.04.07.06.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 06:17:41 -0700 (PDT) Date: Thu, 7 Apr 2022 21:17:38 +0800 From: Muchun Song To: Guo Zhengkui Cc: Andrew Morton , Shuah Khan , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , open list , zhengkui_guo@outlook.com Subject: Re: [PATCH] userfaultfd/selftests: use swap() instead of open coding it Message-ID: References: <20220407123141.4998-1-guozhengkui@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407123141.4998-1-guozhengkui@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2022 at 08:31:41PM +0800, Guo Zhengkui wrote: > Address the following coccicheck warning: > > tools/testing/selftests/vm/userfaultfd.c:1536:21-22: WARNING opportunity > for swap(). > tools/testing/selftests/vm/userfaultfd.c:1540:33-34: WARNING opportunity > for swap(). > > by using swap() for the swapping of variable values and drop > `tmp_area` that is not needed any more. > > `swap()` macro in userfaultfd.c is introduced in commit 681696862bc18 > ("selftests: vm: remove dependecy from internal kernel macros") > > It has been tested with gcc (Debian 8.3.0-6) 8.3.0. > > Signed-off-by: Guo Zhengkui Reviewed-by: Muchun Song Thanks.