From: Mark Brown <broonie@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: wm8994: Add an off-on delay for WM8994 variant
Date: Sun, 27 Mar 2022 23:48:03 +0100 [thread overview]
Message-ID: <YkDpozx+ZmSWwwH0@sirena.org.uk> (raw)
In-Reply-To: <CY4PR04MB05676D46494F722485CE7551CB1C9@CY4PR04MB0567.namprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Sun, Mar 27, 2022 at 03:15:53PM -0700, Jonathan Bakker wrote:
>
> + /* WM8994 requires an off-on delay while others do not */
> + if (ldo->wm8994->type == WM8994)
> + wm8994_ldo_desc[id].off_on_delay = 36000;
You shouldn't modify the description - this wouldn't work in the
unusual situation where there were one of these devices and is a
bad pattern to set in case someone copies this to another device
where it's more likely there could be multiple instances. It is
much better to provide two descriptions and select the one which
is needed at runtime.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-27 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 22:15 Jonathan Bakker
2022-03-27 22:48 ` Mark Brown [this message]
2022-03-28 1:01 ` [PATCH v2] " Jonathan Bakker
2022-03-28 13:11 ` Charles Keepax
2022-03-28 14:36 ` Mark Brown
2022-03-28 14:59 ` Charles Keepax
2022-04-05 9:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkDpozx+ZmSWwwH0@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®