From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E4FC4332F for ; Tue, 29 Mar 2022 16:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232641AbiC2QuE (ORCPT ); Tue, 29 Mar 2022 12:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239884AbiC2QuA (ORCPT ); Tue, 29 Mar 2022 12:50:00 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4768924F283; Tue, 29 Mar 2022 09:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648572496; x=1680108496; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=l79PCfT680tSg5itoW3f+C4BVaO65e08V3oBAzUaQsg=; b=mvTq5SvPLjHI/l9uBUOpTYZmJJVadA8YNncWNLQx+QiakguhpbM4VspM VaxWLPlpIUPknbSNYXY3NLh/XGiiR9Z7RL7idOykqABsWWOMNgzYdcyvp D+PoTKtf+XVq0a594l4/aPxSBaO/X5vbH3x1x/2i9ja96LFpDBNCxuRY0 hvqOCk97ETR1e8ODEmPKXEC+vKERFzlk8vk572oATFZyvvc89WHbS/0af TKmcNBCwKUhfAxsXq9qKfhNP5H+wKm49qkVW1hCaVms9q4fQQxCmgU/Ku LnBhVjXPbgA6+vmE1VxbaCFFosB1r1aJ7Ld+Cfqa4eeVHMa9wZAn/2Ikq w==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="284206058" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="284206058" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 09:42:43 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="554327473" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 09:42:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZEuu-008rb0-Vw; Tue, 29 Mar 2022 19:42:00 +0300 Date: Tue, 29 Mar 2022 19:42:00 +0300 From: Andy Shevchenko To: Neil Armstrong Cc: Qianggui Song , Krzysztof Kozlowski , Fabien Dessenne , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Geert Uytterhoeven , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel Subject: Re: [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_* Message-ID: References: <20220329152926.50958-1-andriy.shevchenko@linux.intel.com> <20220329152926.50958-10-andriy.shevchenko@linux.intel.com> <94e888fe-d8fc-5379-302f-66d64f2ae10b@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <94e888fe-d8fc-5379-302f-66d64f2ae10b@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 06:13:19PM +0200, Neil Armstrong wrote: > On 29/03/2022 17:29, Andy Shevchenko wrote: > > Rename REG_* to * as a prerequisite for enabling COMPILE_TEST. > > What error do you hit ? arch/x86/include/asm/arch_hweight.h:9:17: error: expected identifier before string constant 9 | #define REG_OUT "a" | ^~~ drivers/pinctrl/meson/pinctrl-meson.h:69:9: note: in expansion of macro ‘REG_OUT’ 69 | REG_OUT, And some more. > MREG_ is rather ugly, something like PINCONF_REG_ or more simpler MESON_REG_ would be more appropriate. Fine with me. -- With Best Regards, Andy Shevchenko