From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
"Mike Rapoport" <rppt@kernel.org>,
"Brian Johannesmeyer" <bjohannesmeyer@gmail.com>,
"Cristiano Giuffrida" <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] staging: android: ashmem: remove usage of list iterator after the loop body
Date: Fri, 1 Apr 2022 07:38:49 +0200 [thread overview]
Message-ID: <YkaP6UWmSZjxO/oA@kroah.com> (raw)
In-Reply-To: <20220331213934.866804-1-jakobkoschel@gmail.com>
On Thu, Mar 31, 2022 at 11:39:34PM +0200, Jakob Koschel wrote:
> In preparation to limit the scope of a list iterator to the list
> traversal loop, use a dedicated pointer to point to the found element
> [1].
>
> Before, the code implicitly used the head when no element was found
> when using &pos->list. Since the new variable is only set if an
> element was found, the head needs to be used explicitly if the
> variable is NULL.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
What tree did you make this against? This file is no longer in Linus's
tree.
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-01 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:39 Jakob Koschel
2022-04-01 5:38 ` Greg Kroah-Hartman [this message]
2022-04-01 6:50 ` Jakob Koschel
2022-11-20 10:05 ` IFsuse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkaP6UWmSZjxO/oA@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=bjohannesmeyer@gmail.com \
--cc=brauner@kernel.org \
--cc=c.giuffrida@vu.nl \
--cc=h.j.bos@vu.nl \
--cc=hridya@google.com \
--cc=jakobkoschel@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maco@android.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®