mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function
Date: Sun, 3 Apr 2022 13:16:17 +0200	[thread overview]
Message-ID: <YkmCARvUx7Wg15sH@kroah.com> (raw)
In-Reply-To: <b7551e92f42d60ff3bb74b5e28467f09781e3d06.1648882847.git.philipp.g.hortmann@gmail.com>

On Sat, Apr 02, 2022 at 09:29:49AM +0200, Philipp Hortmann wrote:
> Convert do-while(0) macro PCAvDelayByIO to function and relocate.

That says what you did, but not _why_ you did it.

Please read the kernel documentation again for how to write a good
changelog comment and resend a v2.

thanks,

greg k-h

      parent reply	other threads:[~2022-04-03 11:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02  7:29 [PATCH 0/7] staging: vt6655: Fix CamelCase in upc.h and started in mac.h Philipp Hortmann
2022-04-02  7:29 ` [PATCH 1/7] staging: vt6655: Remove unused macros with do while(0) Philipp Hortmann
2022-04-02  7:29 ` [PATCH 2/7] staging: vt6655: Remove unused macros with CamelCase in mac.h Philipp Hortmann
2022-04-03 11:40   ` Pavel Skripkin
2022-04-02  7:29 ` [PATCH 3/7] staging: vt6655: Rename constant definitions with CamelCase Philipp Hortmann
2022-04-02  7:29 ` [PATCH 4/7] staging: vt6655: Rename macro arguments " Philipp Hortmann
2022-04-02  7:29 ` [PATCH 5/7] staging: vt6655: Rename macros VNSvInPortB,W,D Philipp Hortmann
2022-04-02  7:29 ` [PATCH 6/7] staging: vt6655: Rename macros VNSvOutPortB,W,D Philipp Hortmann
2022-04-02  7:29 ` [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function Philipp Hortmann
2022-04-02 11:05   ` kernel test robot
2022-04-03 11:16   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkmCARvUx7Wg15sH@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®