From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/3] gpiolib: Split out for_each_gpio_desc() macro
Date: Tue, 5 Apr 2022 17:55:09 +0300 [thread overview]
Message-ID: <YkxYTXbJqpBp4H0a@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=McZihs+aKOGE3M5_BW__CTiyX2u2bdS6xc+uHU9RCAZdw@mail.gmail.com>
On Tue, Apr 05, 2022 at 02:21:42PM +0200, Bartosz Golaszewski wrote:
> On Wed, Mar 30, 2022 at 4:59 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > -#define for_each_gpio_desc_with_flag(i, gc, desc, flag) \
> > +#define for_each_gpio_desc(i, gc, desc) \
>
> While at it: how about declaring the i variable in the loop definition?
It will require changes in the users, so, I will do it as a prerequisite
separate change.
> > for (i = 0, desc = gpiochip_get_desc(gc, i); \
> > i < gc->ngpio; \
> > - i++, desc = gpiochip_get_desc(gc, i)) \
> > + i++, desc = gpiochip_get_desc(gc, i))
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-04-05 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 14:59 Andy Shevchenko
2022-03-30 14:59 ` [PATCH v1 2/3] gpiolib: Refactor gpiolib_dbg_show() with help of for_each_gpio_desc() Andy Shevchenko
2022-03-30 14:59 ` [PATCH v1 3/3] gpiolib: Move error message out of a spinlock Andy Shevchenko
2022-04-09 20:36 ` Bartosz Golaszewski
2022-04-05 12:21 ` [PATCH v1 1/3] gpiolib: Split out for_each_gpio_desc() macro Bartosz Golaszewski
2022-04-05 14:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkxYTXbJqpBp4H0a@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®