From: Borislav Petkov <bp@alien8.de>
To: Kai Huang <kai.huang@intel.com>
Cc: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver
Date: Tue, 19 Apr 2022 10:13:12 +0200 [thread overview]
Message-ID: <Yl5vGIfUFp4TfTWk@zn.tnic> (raw)
In-Reply-To: <bd83067542a3519ee4c91f9d50e9bd4fac27e4bb.camel@intel.com>
On Tue, Apr 19, 2022 at 07:47:33PM +1200, Kai Huang wrote:
> From this perspective, I am not sure what's the value of having a dedicated
> INTEL_TDX_ATTESTATION Kconfig. The attestation support code should be turned on
> unconditionally when CONFIG_INTEL_TDX_GUEST is on. The code can also be just
> under arch/x86/coco/tdx/ I guess?
>
> But I'll leave this to maintainers.
Similar story with the unaccepted memory gunk. If it is not going to
be used outside of encrypted guests, why are we polluting our already
insanely humongous Kconfig space with more symbols?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-04-19 8:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 22:01 [PATCH v3 0/4] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-04-15 22:01 ` [PATCH v3 1/4] x86/tdx: Add tdx_mcall_tdreport() API support Kuppuswamy Sathyanarayanan
2022-04-19 2:29 ` Kai Huang
2022-04-19 3:37 ` Sathyanarayanan Kuppuswamy
2022-04-19 3:51 ` Kai Huang
2022-04-19 3:53 ` Sathyanarayanan Kuppuswamy
2022-04-15 22:01 ` [PATCH v3 2/4] x86/tdx: Add tdx_hcall_get_quote() " Kuppuswamy Sathyanarayanan
2022-04-19 2:59 ` Kai Huang
2022-04-19 4:04 ` Sathyanarayanan Kuppuswamy
2022-04-19 4:40 ` Kai Huang
2022-04-19 5:28 ` Sathyanarayanan Kuppuswamy
2022-04-19 7:21 ` Kai Huang
2022-04-20 3:39 ` Aubrey Li
2022-04-20 7:16 ` Sathyanarayanan Kuppuswamy
2022-04-20 8:08 ` Aubrey Li
2022-04-22 17:24 ` Isaku Yamahata
2022-04-25 3:06 ` Aubrey Li
2022-04-15 22:01 ` [PATCH v3 3/4] x86/tdx: Add TDX Guest event notify interrupt support Kuppuswamy Sathyanarayanan
2022-04-15 22:01 ` [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver Kuppuswamy Sathyanarayanan
2022-04-19 7:47 ` Kai Huang
2022-04-19 8:13 ` Borislav Petkov [this message]
2022-04-19 12:48 ` Sathyanarayanan Kuppuswamy
2022-04-20 22:00 ` Borislav Petkov
2022-04-20 22:09 ` Sathyanarayanan Kuppuswamy
2022-04-21 9:10 ` Borislav Petkov
2022-04-21 14:54 ` Sathyanarayanan Kuppuswamy
2022-04-19 8:16 ` Kai Huang
2022-04-19 14:00 ` Sathyanarayanan Kuppuswamy
2022-04-19 22:38 ` Kai Huang
2022-04-19 14:13 ` Dave Hansen
2022-04-19 14:19 ` Sathyanarayanan Kuppuswamy
2022-04-19 14:24 ` Dave Hansen
2022-04-19 14:26 ` Sathyanarayanan Kuppuswamy
2022-04-19 22:21 ` Kai Huang
2022-04-19 22:49 ` Dave Hansen
2022-04-19 23:02 ` Kai Huang
2022-04-20 1:20 ` Isaku Yamahata
2022-04-20 1:26 ` Sathyanarayanan Kuppuswamy
2022-04-21 7:04 ` Isaku Yamahata
2022-04-21 14:44 ` Sathyanarayanan Kuppuswamy
2022-04-20 23:18 ` Kai Huang
2022-04-20 23:45 ` Sathyanarayanan Kuppuswamy
2022-04-21 0:11 ` Kai Huang
2022-04-21 2:42 ` Sathyanarayanan Kuppuswamy
2022-04-21 6:57 ` Isaku Yamahata
2022-04-21 10:33 ` Kai Huang
2022-04-21 14:53 ` Sathyanarayanan Kuppuswamy
2022-04-21 16:53 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl5vGIfUFp4TfTWk@zn.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®