From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D98C433EF for ; Fri, 8 Apr 2022 17:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238396AbiDHR4g (ORCPT ); Fri, 8 Apr 2022 13:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238389AbiDHR4e (ORCPT ); Fri, 8 Apr 2022 13:56:34 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5729AF1E1; Fri, 8 Apr 2022 10:54:29 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id e8-20020a17090a118800b001cb13402ea2so5916390pja.0; Fri, 08 Apr 2022 10:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4Ro5wZmz5/qjQoMRhhyRUYMmqQbliREDVqsZ81z5Kko=; b=XtxAWitQSB4YBg/9d5jI5GEOZ55aoUF9Ezg/KdD/yMNC9r0yJU7zSrbgzPwx18YsZx O7EST5Hup1HYNHyOuU4Gn9xc8kgTc50AWCNDyWpH96BU/O0M7IZLyXntwdM83AvkGJx0 9PBjLSKeeTk3O17dhV6Cbu6xFO80FcqAIZl0Bxf4Gb+VmR1lg8G6R2ByX7tqfRsZwi2X cz34XrBlVXwdt9kcfWX9nfoM9MHeJNJ2omo4yRRqk1a4fZVRvx+lsDRFjzMYYuIxYhB3 vEP/YhRJE9996VGhwLWbVyM+6pqzFpowHBWHijc3tlSK37o4UU2aJAnzuMENi0Bp3wyd WH8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=4Ro5wZmz5/qjQoMRhhyRUYMmqQbliREDVqsZ81z5Kko=; b=XNsIxQag5iSsj/7+1FIh0mWJg4vGbk/wjdXWckm2mvLvx505KSQsXx90RiuurGgRRT FnFWY5ThzhCQkxLPXfQnO1oy7PYQVaZ61vEeUJT7Jpm88i0yLuhUOdazfcEVR9C5yuO7 rZ2hKsrWxIvuj0+tT4etx3Xe2mDQWwMrJvPw8iKE4jVQfy0RxFDLw9n6dR4WQ503jiEz vvhd2ztsrl4rHlBhAYgNFRbngOseSyadhfwKk/eIt2iZFmaKn14EldAVyCBxM1B7BfUA OlS5QYhylTY+RbIfDBlBinsv0xO38UePSkND6dg7/fGzhnkwr6ufzZfP+wpt2+rjA9NF LE8Q== X-Gm-Message-State: AOAM531QHKMuXkKB3QP6k2pHdiDsFqNfYtl9rBlaqkNQgJoLeCiG6DYt ErIFqX5eI1ROnb9TpCfCtTnal2xgq1Q0dw== X-Google-Smtp-Source: ABdhPJzpOVsiqjyFzsypMF/T5dtprIvNQ1QMuoaYPyf6lVh5hncelAnwYlN6Sr471+vxfXLYhNOvsw== X-Received: by 2002:a17:90a:cf94:b0:1ca:7ff9:73eb with SMTP id i20-20020a17090acf9400b001ca7ff973ebmr23206297pju.173.1649440469108; Fri, 08 Apr 2022 10:54:29 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:ab2a]) by smtp.gmail.com with ESMTPSA id q203-20020a632ad4000000b003987c421eb2sm22884266pgq.34.2022.04.08.10.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 10:54:28 -0700 (PDT) Sender: Tejun Heo Date: Fri, 8 Apr 2022 07:54:26 -1000 From: Tejun Heo To: "zhaoyang.huang" Cc: Zefan Li , Johannes Weiner , Zhaoyang Huang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH] cgroup: fix attach task fail when subtree_control configured Message-ID: References: <1649413394-17501-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649413394-17501-1-git-send-email-zhaoyang.huang@unisoc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2022 at 06:23:14PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > It is found that task attach to a vacant cgroup will fail when its > subtree_control has been configured. Fix it by judging if there is no chrildren > existed. > > Signed-off-by: Zhaoyang Huang If I'm not misunderstanding, that's the intended behavior. Can you please take a look at Documentation/admin-guide/cgroup-v2.rst and confirm what you're trying to do? Thanks. -- tejun