From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CF0C433FE for ; Mon, 11 Apr 2022 09:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344672AbiDKJsN (ORCPT ); Mon, 11 Apr 2022 05:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344667AbiDKJr3 (ORCPT ); Mon, 11 Apr 2022 05:47:29 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E44043B2AA for ; Mon, 11 Apr 2022 02:45:14 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A26B0169C; Mon, 11 Apr 2022 02:45:14 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A25483F73B; Mon, 11 Apr 2022 02:45:12 -0700 (PDT) Date: Mon, 11 Apr 2022 10:45:06 +0100 From: Cristian Marussi To: James Morse Cc: 20220217182110.7176-1-james.morse@arm.com, x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, Jamie Iles , D Scott Phillips OS , lcherian@marvell.com, bobo.shaobowang@huawei.com Subject: Re: [PATCH v3 00/21] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2022 at 06:30:40PM +0100, James Morse wrote: > Hi Cristian, > > On 15/03/2022 12:10, Cristian Marussi wrote: > > I tested this on an Intel(R) Xeon(R) Gold 5120T trying to compare gathered > > resctrl monitor data with and without your series and see if results > > were consistent. > > > > I started from this paper [0] from Intel itself for my basic setup with > > some minor variations: > > [..] > > > While doing that I collect in background (and out of node1 processors) all > > the mon_data from the lc_cos group every 100ms and dump those in a file one > > for each cache allocation mask. (mondata_LC_7f0_00f.txt etc) > > > > I tested first against a v5.17-rc1 mainline without your series (named as > > 5.17.0-rc1-mainline in the results) and then again with your series on top > > (named as 5.17.0-rc1-00021-g21c69a5706a5). Got your series from [1]. > > > > Then I used gnuplot to see what was the 'profile' of this data with and > > without your series by plotting the LC process llc_occupancy data against > > time for each one of the runs with the differerent cache allocated. > > (each colored graphs represent a different run with a different > > cache allocation as reported) > > > Hope this helps... > Hi James, > This is great, thanks! > > Can I take this as a Tested-by? > Sure, sorry to have forgot that :D Tested-by: Cristian Marussi Thanks, Cristian