From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1523CC433FE for ; Wed, 13 Apr 2022 11:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235295AbiDMLve (ORCPT ); Wed, 13 Apr 2022 07:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiDMLvd (ORCPT ); Wed, 13 Apr 2022 07:51:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A765AEE3; Wed, 13 Apr 2022 04:49:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E62B661DED; Wed, 13 Apr 2022 11:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68962C385A3; Wed, 13 Apr 2022 11:49:10 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="bfKghglO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1649850548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q8Ex0PxSMkX6hLvtleAT2Su1yp40GVqczv/isAdXg5A=; b=bfKghglOXKd8bI5FupKt8r0GvzCdggBiAJl20u1AmZ0Jt8yh1RsaEkpS49+Zt06rAVWxf3 NO2bU7iJMYLIgAmKhUZ1Xhama/JBzEZ/0Oy3M8eXJyB2zjVjGq9BqX7F863Ew6VVm8wuVV FKvh6oX4HU6XEoKjS4laHtOOgeR7JEU= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 69785bfc (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 13 Apr 2022 11:49:08 +0000 (UTC) Date: Wed, 13 Apr 2022 13:48:53 +0200 From: "Jason A. Donenfeld" To: Will Deacon Cc: Tianjia Zhang , Herbert Xu , "David S. Miller" , Catalin Marinas , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm64/sm4 - Fix wrong dependency of NEON/CE implementation Message-ID: References: <20220411031313.35449-1-tianjia.zhang@linux.alibaba.com> <20220413102209.GB1229@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220413102209.GB1229@willie-the-truck> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On Wed, Apr 13, 2022 at 11:22:09AM +0100, Will Deacon wrote: > On Mon, Apr 11, 2022 at 11:13:13AM +0800, Tianjia Zhang wrote: > > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > > moved the sm4 library implementation from the lib/crypto directory to > > the crypto directory and configured the name as CRYPTO_SM4. The arm64 > > SM4 NEON/CE implementation depends on this and needs to be modified > > uniformly. > > d2825fa9365d doesn't appear in my tree -- is this something in linux-next? This is in Herbert's tree for next: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=d2825fa9365d Jason