From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591C2C433F5 for ; Thu, 14 Apr 2022 16:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243393AbiDNQHk (ORCPT ); Thu, 14 Apr 2022 12:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351574AbiDNP5a (ORCPT ); Thu, 14 Apr 2022 11:57:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3753444A33; Thu, 14 Apr 2022 08:42:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0718B82A70; Thu, 14 Apr 2022 15:42:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB2E7C385A5; Thu, 14 Apr 2022 15:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649950935; bh=pkfByiWfFuRJ/KrgPwqFe3DcHz82RVQhum60vPKjzsE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VEUq2xRRQvXfQjrUUpTvzE4VNKsrXB42lRgtFqzWoREZO4Q9eCj+F0Fn1CVfV9Jg4 f7NAY9ondPJlN5WuXpVCw+z00pFi6mzQtkeGieRgUpiRR4wYQXfbfeEGKhmPqUXYkl tE6gJg1yk4FJcsV9/thanwYuBcUNyLFtzwyS4zp0= Date: Thu, 14 Apr 2022 17:42:12 +0200 From: Greg KH To: Waiman Long Cc: john.p.donnelly@oracle.com, chenguanyou , dave@stgolabs.net, hdanton@sina.com, linux-kernel@vger.kernel.org, mazhenhua@xiaomi.com, mingo@redhat.com, peterz@infradead.org, quic_aiquny@quicinc.com, will@kernel.org, sashal@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Message-ID: References: <20211116012912.723980-1-longman@redhat.com> <20220214154741.12399-1-chenguanyou@xiaomi.com> <3f02975c-1a9d-be20-32cf-f1d8e3dfafcc@oracle.com> <31178c33-e25c-c3e8-35e2-776b5211200c@oracle.com> <161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com> <2b6ed542-b3e0-1a87-33ac-d52fc0e0339c@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 11:18:23AM -0400, Waiman Long wrote: > On 4/14/22 06:48, Greg KH wrote: > > On Tue, Apr 12, 2022 at 01:04:05PM -0400, Waiman Long wrote: > > > The patch has already been in the tip tree. It may not be easy to add a > > > Fixes tag to it. Anyway, I will encourage stable tree maintainer to take it > > > as it does fix a problem as shown in your test. > > I have no idea what you want me to do here. Please be explicit... > > > I would like the stable trees to include commit 1ee326196c66 > ("locking/rwsem: Always try to wake waiters in out_nolock path") after it is > merged into the mainline in the v5.19 merge window. It should be applied to > the stable trees that have incorporated the backport of commit d257cc8cb8d5 > ("locking/rwsem: Make handoff bit handling more consistent") since this > commit seems to make the missed wakeup problem easier to show up. Please let us know when this is merged into Linus's tree. Nothing we can do until then and I'm not going to remember this in a few months anyway. thanks, greg k-h