From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] dt-bindings: mmc: convert sdhci-dove to JSON schema
Date: Fri, 15 Apr 2022 01:33:04 +0200 [thread overview]
Message-ID: <YlivMII9rDCcB6lk@lunn.ch> (raw)
In-Reply-To: <20220414230603.567049-5-chris.packham@alliedtelesis.co.nz>
Hi Chris
> +required:
> + - compatible
> + - reg
> + - interrupts
https://elixir.bootlin.com/linux/latest/source/drivers/mmc/host/sdhci-dove.c#L78
https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/dove.dtsi#L344
Dove does actually have a clock. It looks like it is optional in the
driver, but the .dtsi file has it. It is not documented in the current
.txt file, so i can understand you missing it.
I'm surprised the DT tools didn't complain about an unexpected
property.
Andrew
next prev parent reply other threads:[~2022-04-14 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 23:05 [PATCH 0/4] dt-bindings: mmc: Convert orion/dove bindings " Chris Packham
2022-04-14 23:06 ` [PATCH 1/4] ARM: dts: mvebu: Update mvsdio node names to match schema Chris Packham
2022-04-14 23:06 ` [PATCH 2/4] ARM: dts: dove: Update sdio-host " Chris Packham
2022-04-14 23:06 ` [PATCH 3/4] dt-bindings: mmc: convert orion-sdio to JSON schema Chris Packham
2022-04-15 14:32 ` Rob Herring
2022-04-20 21:16 ` Rob Herring
2022-04-18 11:41 ` Krzysztof Kozlowski
2022-04-14 23:06 ` [PATCH 4/4] dt-bindings: mmc: convert sdhci-dove " Chris Packham
2022-04-14 23:33 ` Andrew Lunn [this message]
2022-04-18 11:43 ` Krzysztof Kozlowski
2022-04-15 14:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlivMII9rDCcB6lk@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®