From: Luis Chamberlain <mcgrof@kernel.org>
To: Russ Weight <russell.h.weight@intel.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com,
lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com, basheer.ahmed.muddebihal@intel.com,
tianfei.zhang@intel.com
Subject: Re: [PATCH v2 4/8] firmware_loader: Add firmware-upload support
Date: Fri, 15 Apr 2022 15:55:04 -0700 [thread overview]
Message-ID: <Yln3yCsPK9Za2jbu@bombadil.infradead.org> (raw)
In-Reply-To: <20220415200805.610339-5-russell.h.weight@intel.com>
On Fri, Apr 15, 2022 at 01:08:01PM -0700, Russ Weight wrote:
> +EXPORT_SYMBOL_GPL(firmware_upload_unregister);
> diff --git a/drivers/base/firmware_loader/sysfs_upload.h b/drivers/base/firmware_loader/sysfs_upload.h
> new file mode 100644
> index 000000000000..a72d0e82e107
> --- /dev/null
> +++ b/drivers/base/firmware_loader/sysfs_upload.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __FIRMWARE_UPLOAD_H
> +#define __FIRMWARE_UPLOAD_H
> +
> +#include <linux/device.h>
> +
> +/* Update progress codes */
> +enum fw_upload_prog {
> + FW_UPLOAD_PROG_IDLE,
> + FW_UPLOAD_PROG_RECEIVING,
> + FW_UPLOAD_PROG_PREPARING,
> + FW_UPLOAD_PROG_TRANSFERRING,
> + FW_UPLOAD_PROG_PROGRAMMING,
> + FW_UPLOAD_PROG_MAX
> +};
This is all looking good to me, thanks for all the work and testing!
Can you just add kdoc entries for the above as well?
Other than that:
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
next prev parent reply other threads:[~2022-04-15 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 20:07 [PATCH v2 0/8] Extend FW framework for user FW uploads Russ Weight
2022-04-15 20:07 ` [PATCH v2 1/8] firmware_loader: Clear data and size in fw_free_paged_buf Russ Weight
2022-04-15 20:07 ` [PATCH v2 2/8] firmware_loader: Check fw_state_is_done in loading_store Russ Weight
2022-04-15 20:08 ` [PATCH v2 3/8] firmware_loader: Split sysfs support from fallback Russ Weight
2022-04-15 20:08 ` [PATCH v2 4/8] firmware_loader: Add firmware-upload support Russ Weight
2022-04-15 22:55 ` Luis Chamberlain [this message]
2022-04-15 20:08 ` [PATCH v2 5/8] firmware_loader: Add sysfs nodes to monitor fw_upload Russ Weight
2022-04-15 20:08 ` [PATCH v2 6/8] test_firmware: Add test support for firmware upload Russ Weight
2022-04-15 20:08 ` [PATCH v2 7/8] test_firmware: Error injection " Russ Weight
2022-04-15 20:08 ` [PATCH v2 8/8] selftests: firmware: Add firmware upload selftests Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yln3yCsPK9Za2jbu@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=basheer.ahmed.muddebihal@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®