From: Peter Zijlstra <peterz@infradead.org>
To: Tom Rix <trix@redhat.com>
Cc: jpoimboe@redhat.com, mingo@kernel.org, bp@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: rework error handling in objtool_create_backup
Date: Sat, 30 Apr 2022 19:40:11 +0200 [thread overview]
Message-ID: <Ym10e9oSyKXOopJv@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220430173240.3346735-1-trix@redhat.com>
On Sat, Apr 30, 2022 at 01:32:40PM -0400, Tom Rix wrote:
> The cppcheck reports this issue
> [tools/objtool/objtool.c:65]: (error) Memory leak: name
>
> This is a general problem. When ojbtool_create_backup() fails anywhere it
> returns an error without freeing any of the buffers it allocates. So
> rework the error handler to goto the appropriate free level when an error
> occurs.
If it fails, objtool terminates. Process termination releases all
resources.
prev parent reply other threads:[~2022-04-30 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 17:32 Tom Rix
2022-04-30 17:40 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym10e9oSyKXOopJv@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®