From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A564C4332F for ; Thu, 21 Apr 2022 09:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387690AbiDUJe6 (ORCPT ); Thu, 21 Apr 2022 05:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387677AbiDUJey (ORCPT ); Thu, 21 Apr 2022 05:34:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5B4E1572F; Thu, 21 Apr 2022 02:32:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6916AB823A7; Thu, 21 Apr 2022 09:32:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B45BC385A1; Thu, 21 Apr 2022 09:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650533522; bh=5tCYODYe4IUZwtg/8f/XY3fbdkY0KtrDaNGpzi8qFUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yfswzQHoys+STXSwb/IAa5il79nk+s0bn4xbXaq3LJUY4T+natHRxo3gFMZnnHrbr qWtKCmV/Tu/jUBHnKejgruocGkKwQ0AY/s+DLkOHXVgjQPhCrkzNF0uLywNsqc1x/4 z88Hhlly+u+82ml4UqP+bBAjzPnflGgUiB3akSNY= Date: Thu, 21 Apr 2022 11:31:59 +0200 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Mathias Nyman , "Sandeep Maheswaram (Temp) (QUIC)" , Felipe Balbi , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Mathias Nyman , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Pavan Kumar Kondeti (QUIC)" , "Pratham Pratap (QUIC)" , "Krishna Kurapati PSSNV (QUIC)" , "Vidya Sagar Pulyala (Temp) (QUIC)" Subject: Re: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers Message-ID: References: <1649323888-12420-1-git-send-email-quic_c_sanm@quicinc.com> <4b34735f-8e1f-bf37-398f-9b4a8aa2e939@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 11:41:33AM +0300, Heikki Krogerus wrote: > On Thu, Apr 21, 2022 at 10:36:57AM +0200, Greg Kroah-Hartman wrote: > > On Thu, Apr 21, 2022 at 10:46:37AM +0300, Heikki Krogerus wrote: > > > On Wed, Apr 20, 2022 at 04:20:52PM +0300, Mathias Nyman wrote: > > > > On 19.4.2022 13.17, Sandeep Maheswaram (Temp) (QUIC) wrote: > > > > > Hi Mathias, Felipe, > > > > > > > > > >> -----Original Message----- > > > > >> From: Sandeep Maheswaram (Temp) (QUIC) > > > > >> Sent: Thursday, April 7, 2022 3:01 PM > > > > >> To: Greg Kroah-Hartman ; Felipe Balbi > > > > >> ; Stephen Boyd ; Doug > > > > >> Anderson ; Matthias Kaehlcke > > > > >> ; Mathias Nyman > > > > >> Cc: linux-arm-msm@vger.kernel.org; linux-usb@vger.kernel.org; linux- > > > > >> kernel@vger.kernel.org; Pavan Kumar Kondeti (QUIC) > > > > >> ; Pratham Pratap (QUIC) > > > > >> ; Krishna Kurapati PSSNV (QUIC) > > > > >> ; Vidya Sagar Pulyala (Temp) (QUIC) > > > > >> ; Sandeep Maheswaram (Temp) (QUIC) > > > > >> > > > > >> Subject: [PATCH v3 0/2] Skip phy initialization for DWC3 USB Controllers > > > > >> > > > > >> Runtime suspend of phy drivers was failing from DWC3 driver as runtime > > > > >> usage value is 2 because the phy is initialized from > > > > >> DWC3 core and HCD core. > > > > >> Some controllers like DWC3 and CDNS3 manage phy in their core drivers. > > > > >> This property can be set to avoid phy initialization in HCD core. > > > > >> > > > > >> v3: > > > > >> Coming back to this series based on discussion at below thread > > > > >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1648103831- > > > > >> 12347-4-git-send-email-quic_c_sanm@quicinc.com/ > > > > >> Dropped the dt bindings PATCH 1/3 in v2 > > > > >> https://patchwork.kernel.org/project/linux-arm-msm/cover/1636353710- > > > > >> 25582-1-git-send-email-quic_c_sanm@quicinc.com/ > > > > >> > > > > >> v2: > > > > >> Updated the commit descriptions. > > > > >> Changed subject prefix from dwc to dwc3. > > > > >> Increased props array size. > > > > >> > > > > >> Sandeep Maheswaram (2): > > > > >> usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT > > > > >> quirk > > > > >> usb: dwc3: host: Set the property usb-skip-phy-init > > > > >> > > > > >> drivers/usb/dwc3/host.c | 4 +++- > > > > >> drivers/usb/host/xhci-plat.c | 3 +++ > > > > >> 2 files changed, 6 insertions(+), 1 deletion(-) > > > > >> > > > > >> -- > > > > >> 2.7.4 > > > > > > > > > > Please let me know your opinion about this series. > > > > > > > > Otherwise looks good but wondering if we should document that new device > > > > property somewhere. > > > > > > > > Couldn't find a standard way how those device properties excluded from > > > > Documentation/devicetree/binding are documented > > > > > > Couldn't it be just documented in drivers/usb/host/xhci-plat.c for now? > > > > That's not where DT properties are documented. > > It's not a DT property. Then what is it and why are the other properties documented? Anyway, a new series has been submitted that does document this so I don't think it's an argument anymore :)