From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E1DC433F5 for ; Thu, 21 Apr 2022 13:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230046AbiDUNGP (ORCPT ); Thu, 21 Apr 2022 09:06:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiDUNGL (ORCPT ); Thu, 21 Apr 2022 09:06:11 -0400 Received: from out199-9.us.a.mail.aliyun.com (out199-9.us.a.mail.aliyun.com [47.90.199.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E4E3338B5; Thu, 21 Apr 2022 06:03:20 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VAf7aqz_1650546191; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VAf7aqz_1650546191) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Apr 2022 21:03:14 +0800 Date: Thu, 21 Apr 2022 21:03:11 +0800 From: Gao Xiang To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com Subject: Re: [PATCH v9 17/21] erofs: implement fscache-based metadata read Message-ID: Mail-Followup-To: Jeffle Xu , dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com References: <20220415123614.54024-1-jefflexu@linux.alibaba.com> <20220415123614.54024-18-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220415123614.54024-18-jefflexu@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2022 at 08:36:10PM +0800, Jeffle Xu wrote: > Implement the data plane of reading metadata from primary data blob > over fscache. > > Signed-off-by: Jeffle Xu > --- > fs/erofs/data.c | 19 +++++++++++++++---- > fs/erofs/fscache.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+), 4 deletions(-) > > diff --git a/fs/erofs/data.c b/fs/erofs/data.c > index 14b64d960541..bb9c1fd48c19 100644 > --- a/fs/erofs/data.c > +++ b/fs/erofs/data.c > @@ -6,6 +6,7 @@ > */ > #include "internal.h" > #include > +#include > #include > #include > > @@ -35,14 +36,20 @@ void *erofs_bread(struct erofs_buf *buf, struct inode *inode, > erofs_off_t offset = blknr_to_addr(blkaddr); > pgoff_t index = offset >> PAGE_SHIFT; > struct page *page = buf->page; > + struct folio *folio; > + unsigned int nofs_flag; > > if (!page || page->index != index) { > erofs_put_metabuf(buf); > - page = read_cache_page_gfp(mapping, index, > - mapping_gfp_constraint(mapping, ~__GFP_FS)); > - if (IS_ERR(page)) > - return page; > + > + nofs_flag = memalloc_nofs_save(); > + folio = read_cache_folio(mapping, index, NULL, NULL); > + memalloc_nofs_restore(nofs_flag); > + if (IS_ERR(folio)) > + return folio; > + > /* should already be PageUptodate, no need to lock page */ > + page = folio_file_page(folio, index); > buf->page = page; > } > if (buf->kmap_type == EROFS_NO_KMAP) { > @@ -63,6 +70,10 @@ void *erofs_bread(struct erofs_buf *buf, struct inode *inode, > void *erofs_read_metabuf(struct erofs_buf *buf, struct super_block *sb, > erofs_blk_t blkaddr, enum erofs_kmap_type type) > { > + if (erofs_is_fscache_mode(sb)) > + return erofs_bread(buf, EROFS_SB(sb)->s_fscache->inode, > + blkaddr, type); > + > return erofs_bread(buf, sb->s_bdev->bd_inode, blkaddr, type); > } > > diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c > index 066f68c062e2..3f00eb34ac35 100644 > --- a/fs/erofs/fscache.c > +++ b/fs/erofs/fscache.c > @@ -58,7 +58,34 @@ static int erofs_fscache_read_folios(struct fscache_cookie *cookie, > return ret; > } > > +static int erofs_fscache_meta_readpage(struct file *data, struct page *page) > +{ > + int ret; > + struct folio *folio = page_folio(page); > + struct super_block *sb = folio_mapping(folio)->host->i_sb; > + struct erofs_map_dev mdev = { > + .m_deviceid = 0, > + .m_pa = folio_pos(folio), > + }; > + > + ret = erofs_map_dev(sb, &mdev); > + if (ret) > + goto out; > + > + ret = erofs_fscache_read_folios(mdev.m_fscache->cookie, > + folio_mapping(folio), folio_pos(folio), > + folio_size(folio), mdev.m_pa); > + if (ret) > + goto out; > + > + folio_mark_uptodate(folio); if (!ret) folio_mark_uptodate(folio); Thanks, Gao Xiang > +out: > + folio_unlock(folio); > + return ret; > +} > + > static const struct address_space_operations erofs_fscache_meta_aops = { > + .readpage = erofs_fscache_meta_readpage, > }; > > /* > -- > 2.27.0