From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55A0C433F5 for ; Fri, 22 Apr 2022 13:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1448139AbiDVNrM (ORCPT ); Fri, 22 Apr 2022 09:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388465AbiDVNrF (ORCPT ); Fri, 22 Apr 2022 09:47:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A88958E74 for ; Fri, 22 Apr 2022 06:44:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25CCD620D4 for ; Fri, 22 Apr 2022 13:44:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E27C385A4; Fri, 22 Apr 2022 13:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650635051; bh=h7Ecm6MBAXN+s9MsujnvJUtmyfXyAIH8LNTgBqNYka4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nGMIJmBxeBZYmhUuOcxv9FL3/A5lAEqMseKDyEMox0CvEpb1i53+tIFpUtFeX2AJs N9zBTswiTuY9wl35PTkKRfTywkP34vv8WtRb1tqVdtJy2gMjQEZWqVXxot2Nnf9Qiz rUdZKCSR4PRLlqqyOaqzKeFaQgWFGwjQ9FFHn7K8= Date: Fri, 22 Apr 2022 15:44:09 +0200 From: Greg KH To: =?utf-8?B?6IGC5rGf56OK?= Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: vt: consolemap: Add missing kfree() in con_do_clear_unimap() Message-ID: References: <20220303020630.460257-1-niejianglei2021@163.com> <4a7fe3ca.68b6.17f6eacb952.Coremail.niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a7fe3ca.68b6.17f6eacb952.Coremail.niejianglei2021@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 09, 2022 at 08:34:47PM +0800, 聂江磊 wrote: > I found this bug by using clang static analyse checkers. I found that function con_release_unimap() is only called in this file(drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c). There are totally 5 times that con_release_unimap() is called > > (line 430, 466, 522, 599, 673) while con_release_unimap() is not followed by kfree() only in line 522. So I think it is a bug > > and make this patch. Given that we do not have any reports of this leaking memory, I do not think your analysis is correct, so I am loath to apply this, sorry. greg k-h