From: Luis Chamberlain <mcgrof@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: k@ava.usersys.com, cl@linux.com, pmladek@suse.com,
mbenes@suse.cz, christophe.leroy@csgroup.eu,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, atomlin@atomlin.com,
ghalat@redhat.com, oleksandr@natalenko.name, neelx@redhat.com
Subject: Re: [PATCH v4 0/2] module: Introduce module unload taint tracking
Date: Tue, 26 Apr 2022 09:22:53 -0700 [thread overview]
Message-ID: <YmgcXSXTM80/3R8b@bombadil.infradead.org> (raw)
In-Reply-To: <20220426083930.hltsfxoe6ax6dspj@ava.usersys.com>
On Tue, Apr 26, 2022 at 09:39:30AM +0100, Aaron Tomlin wrote:
> On Mon 2022-04-25 16:31 -0700, Luis Chamberlain wrote:
> > This all looks good except with all the work you did to remove
> > #ifdef hell, it gets me wondering why not just use a new file for this?
> >
> > What does that look like?
>
> Hi Luis,
>
> I thought about it. It is indeed possible. Yet, I do not think it is worth
> it, for such a small change; albeit, what do you prefer?
I'd rather see the effort than not, given all the effort to already split things.
I think it keeps things pretty tidy and it can scale / and its easier to review.
Luis
next prev parent reply other threads:[~2022-04-26 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 9:08 Aaron Tomlin
2022-04-25 9:08 ` [PATCH v4 1/2] module: Make module_flags_taint() accept a module's taints bitmap directly Aaron Tomlin
2022-04-25 9:08 ` [PATCH v4 2/2] module: Introduce module unload taint tracking Aaron Tomlin
2022-05-02 11:07 ` Christophe Leroy
2022-05-02 18:45 ` Aaron Tomlin
2022-04-25 23:31 ` [PATCH v4 0/2] " Luis Chamberlain
2022-04-26 8:39 ` Aaron Tomlin
2022-04-26 16:22 ` Luis Chamberlain [this message]
2022-04-27 9:07 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmgcXSXTM80/3R8b@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=k@ava.usersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=neelx@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®