From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
aaronyu@google.com, matthias.bgg@gmail.com,
trevor.wu@mediatek.com, tzungbi@google.com,
julianbraha@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v4 07/18] ASoC: mediatek: mt8186: support i2s in platform driver
Date: Thu, 28 Apr 2022 13:13:47 +0100 [thread overview]
Message-ID: <YmqE+80xyBoIJvto@sirena.org.uk> (raw)
In-Reply-To: <20220428093355.16172-8-jiaxin.yu@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On Thu, Apr 28, 2022 at 05:33:44PM +0800, Jiaxin Yu wrote:
> +/* clock source control */
> +static const char * const mt8186_i2s_src_str[] = {
> + "Master", "Slave"
> +};
> +
> +static const struct soc_enum mt8186_i2s_src_enum[] = {
> + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(mt8186_i2s_src_str),
> + mt8186_i2s_src_str),
> +};
Not clear why this is user visible? Shouldn't the machine driver be
setting this. Also please use more modern provider/consumer terminology
for the clocking.
> +static int mt8186_i2s_hd_set(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + return -EINVAL;
> + }
> +
> + i2s_priv->low_jitter_en = hd_en;
> +
> + return 0;
> +}
Same issue as on the other patch with the events - like I said there
mixer-test will find a bunch of these issues for you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-28 12:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 9:33 [v4 00/18] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-04-28 9:33 ` [v4 01/18] ASoC: mediatek: mt6366: support for mt6366 codec Jiaxin Yu
2022-04-28 9:33 ` [v4 02/18] dt-bindings: mediatek: mt6358: add new compatible for using mt6366 Jiaxin Yu
2022-04-28 9:33 ` [v4 03/18] ASoC: mediatek: mt8186: support audsys clock control Jiaxin Yu
2022-04-28 9:33 ` [v4 04/18] ASoC: mediatek: mt8186: support adda in platform driver Jiaxin Yu
2022-04-28 9:33 ` [v4 05/18] ASoC: mediatek: mt8186: support hostless " Jiaxin Yu
2022-04-28 9:33 ` [v4 06/18] ASoC: mediatek: mt8186: support hw gain " Jiaxin Yu
2022-04-28 9:33 ` [v4 07/18] ASoC: mediatek: mt8186: support i2s " Jiaxin Yu
2022-04-28 12:13 ` Mark Brown [this message]
2022-04-29 9:56 ` Jiaxin Yu
2022-04-28 9:33 ` [v4 08/18] ASoC: mediatek: mt8186: support pcm " Jiaxin Yu
2022-04-28 9:33 ` [v4 09/18] ASoC: mediatek: mt8186: support src " Jiaxin Yu
2022-04-28 9:33 ` [v4 10/18] ASoC: mediatek: mt8186: support tdm " Jiaxin Yu
2022-04-28 9:33 ` [v4 11/18] ASoC: mediatek: mt8186: support audio clock control " Jiaxin Yu
2022-04-28 9:33 ` [v4 12/18] ASoC: mediatek: mt8186: support gpio " Jiaxin Yu
2022-04-28 9:33 ` [v4 13/18] ASoC: mediatek: mt8186: add " Jiaxin Yu
2022-04-28 12:02 ` Mark Brown
2022-04-29 10:07 ` Jiaxin Yu
2022-04-28 9:33 ` [v4 14/18] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-05-03 19:29 ` Rob Herring
2022-04-28 9:33 ` [v4 15/18] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-04-28 9:33 ` [v4 16/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-04-28 12:17 ` Rob Herring
2022-04-28 14:31 ` Rob Herring
2022-04-29 9:40 ` Jiaxin Yu
2022-04-29 20:16 ` Rob Herring
2022-04-28 9:33 ` [v4 17/18] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s Jiaxin Yu
2022-04-28 9:33 ` [v4 18/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document Jiaxin Yu
2022-04-28 12:17 ` Rob Herring
2022-04-28 14:31 ` Rob Herring
2022-04-28 12:19 ` [v4 00/18] ASoC: mediatek: Add support for MT8186 SoC Mark Brown
2022-04-29 9:21 ` Jiaxin Yu
2022-04-29 8:47 ` Geert Uytterhoeven
2022-04-29 9:15 ` Jiaxin Yu
2022-04-29 12:49 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmqE+80xyBoIJvto@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=julianbraha@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®