From: Peter Xu <peterx@redhat.com>
To: Hongchen Zhang <zhanghongchen@loongson.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alistair Popple <apopple@nvidia.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swapops: make is_pmd_migration_entry more strict
Date: Fri, 29 Apr 2022 09:31:03 -0400 [thread overview]
Message-ID: <Ymvol9Ffa5/fh7Jw@xz-m1.local> (raw)
In-Reply-To: <752b59ff-3283-2360-5f16-d75d04c25a8b@loongson.cn>
On Fri, Apr 29, 2022 at 10:23:08AM +0800, Hongchen Zhang wrote:
> Hello Peter,
Hi, Hongchen,
> (1) the pmd passed to __split_huge_pmd_locked may be a none pmd,so it may
> be wrongly treated as a pmd migration entry.
With !ARCH_ENABLE_THP_MIGRATION is_pmd_migration_entry() returns 0
constantly.
> (2) we are preparing to support thp migration on MIPS.
Makes sense (to not have Fixes then). It'll be great if the objective of
the patch will be mentioned in the future.
Thanks for answering!
--
Peter Xu
prev parent reply other threads:[~2022-04-29 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 7:35 Hongchen Zhang
2022-04-28 18:41 ` Peter Xu
2022-04-29 2:23 ` Hongchen Zhang
2022-04-29 13:31 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymvol9Ffa5/fh7Jw@xz-m1.local \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=rcampbell@nvidia.com \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®