From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D8CC433FE for ; Thu, 5 May 2022 13:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379015AbiEENVH (ORCPT ); Thu, 5 May 2022 09:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379004AbiEENVE (ORCPT ); Thu, 5 May 2022 09:21:04 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FB0232ED5; Thu, 5 May 2022 06:17:25 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248013547" X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="248013547" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 06:17:08 -0700 X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="654216218" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 06:17:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nmbLp-00CI1C-TO; Thu, 05 May 2022 16:17:01 +0300 Date: Thu, 5 May 2022 16:17:01 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Neil Armstrong , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-amlogic , Linux Kernel Mailing List , Linus Walleij , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek Szyprowski Subject: Re: [PATCH v5 1/6] gpiolib: Introduce a helper to get first GPIO controller node Message-ID: References: <20220414190242.22178-1-andriy.shevchenko@linux.intel.com> <20220414190242.22178-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 03:05:52PM +0200, Bartosz Golaszewski wrote: > On Tue, Apr 26, 2022 at 12:29 PM Andy Shevchenko > wrote: > > On Tue, Apr 26, 2022 at 12:27 AM Bartosz Golaszewski wrote: > > > On Thu, Apr 14, 2022 at 9:02 PM Andy Shevchenko > > > wrote: ... > > > Any chance you could name it get_first_gpiochip_node()? It's static so > > > we don't have to worry about the prefix and it would make the purpose > > > more clear. > > > > There are two things why I prefer it as is: > > 1) it's static inline, so it's part of (internal) but still exported API; > > 2) it's already in my for-next branch which I would like not to > > rebase, until it's a really serious issue. > > > > That said, if you still insist I can rename it. > > No that's fine and I also pulled that into my tree. Thank you! -- With Best Regards, Andy Shevchenko