From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301EAC433F5 for ; Thu, 5 May 2022 22:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346416AbiEEWjN (ORCPT ); Thu, 5 May 2022 18:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386467AbiEEWia (ORCPT ); Thu, 5 May 2022 18:38:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15B6E6007A for ; Thu, 5 May 2022 15:34:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A28B61F51 for ; Thu, 5 May 2022 22:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA4FAC385A4; Thu, 5 May 2022 22:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651790084; bh=fIcmMOB4OTzUhPRJw5zxd1he8Ws9Ea91j5a5noC1OwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dDjiqn3iXIxsl95pJLRm9hrJchx4WfXEocyDn8SVGogcQ5ZgMmKnU384LgZ4FZvGP cjgJqRC9zMQbrvZDuSbZJQboS77aP9g4SNbH88A0AC0dxpNfh0xc6f9SX6tp/JwV94 q2boySmrpnWmzzZqy8AB0OIdh4Qd7DbjWk6tC+fI= Date: Thu, 5 May 2022 23:10:43 +0200 From: Greg Kroah-Hartman To: Tinghan Shen Cc: Matthias Brugger , Javier Martinez Canillas , Thomas Zimmermann , Sudeep Holla , Bjorn Andersson , Borislav Petkov , Michal Suchanek , Cristian Marussi , Etienne Carriere , Arnd Bergmann , Daniel Vetter , Simon Trimmer , John Stultz , Pierre-Louis Bossart , AngeloGioacchino Del Regno , Allen-KH Cheng , YC Hung , Tzung-Bi Shih , Curtis Malainey , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, alsa-devel@alsa-project.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [RESEND PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface Message-ID: References: <20220505053048.13804-1-tinghan.shen@mediatek.com> <20220505053048.13804-2-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505053048.13804-2-tinghan.shen@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 01:30:48PM +0800, Tinghan Shen wrote: > From: TingHan Shen > > Some of mediatek processors contain > the Tensilica HiFix DSP for audio processing. > > The communication between Host CPU and DSP firmware is > taking place using a shared memory area for message passing. > > ADSP IPC protocol offers (send/recv) interfaces using > mediatek-mailbox APIs. > > We use two mbox channels to implement a request-reply protocol. > > Signed-off-by: Allen-KH Cheng > Signed-off-by: TingHan Shen > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Curtis Malainey > Reviewed-by: Tzung-Bi Shih > Reviewed-by: YC Hung > Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/mediatek/Kconfig | 9 + > drivers/firmware/mediatek/Makefile | 2 + > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > 6 files changed, 239 insertions(+) > create mode 100644 drivers/firmware/mediatek/Kconfig > create mode 100644 drivers/firmware/mediatek/Makefile > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h Why do you have a .h file, and export symbols in your .c file, yet you have no user of these symbols or header file? Without a user, we can not take this, sorry. This should just be one single .c file. Also, why a whole subdirectory for just one .c file? thanks, greg k-h