From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0879DC433F5 for ; Fri, 6 May 2022 15:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442610AbiEFPK0 (ORCPT ); Fri, 6 May 2022 11:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442675AbiEFPKX (ORCPT ); Fri, 6 May 2022 11:10:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534276D195 for ; Fri, 6 May 2022 08:06:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04CAFB83615 for ; Fri, 6 May 2022 15:06:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0254C385A8; Fri, 6 May 2022 15:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651849595; bh=Iptv53vFJdhpTSGnrF5kGqg5MMjPl4LVxL18KjOlJdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BOeD6zMCOEgi2nA2dh7h5wq6MvnRPFqEYkIiCxR5QL93OvqcpQgmFDJiqfHl6S7E0 P2htJJ6aGVDVXyu8L5Mi6L8i04N1QQ4t95AprtM4Jl9amUCADeCsh2Ghd5gASS+jKf xR0FNfznCpAtqAloZ3ZIsh4BoL/KVDznYqZn4V0mVJ45yRRV/0S0SQlHn8LdP7bjA+ FV0yvq8C9GDQc3OI4JJ7+7cbQNJo+2kGvNlW8FE7X5tfta5IHfiGWUQKlrLgY/CRV3 Y9X0rXYOmjxTjmD2HjXjFLtlKEa3FmhPVQ+sDnE2gFo779YNP+UnLTuiEvAOzbE7fl DHa4iKDssodLg== Date: Fri, 6 May 2022 08:06:33 -0700 From: Nathan Chancellor To: Jens Axboe , Christoph Hellwig , Keith Busch , Sagi Grimberg Cc: Nick Desaulniers , Tom Rix , Kanchan Joshi , Anuj Gupta , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel test robot Subject: Re: [PATCH] nvme: Ensure ret is always initialized in Message-ID: References: <20220506150357.2443040-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220506150357.2443040-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ugh, subject should be: nvme: Ensure ret is always initialized in nvme_ns_head_chr_uring_cmd() I can resend if this is the correct thing to do. On Fri, May 06, 2022 at 08:03:58AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/nvme/host/ioctl.c:674:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (ns) > ^~ > drivers/nvme/host/ioctl.c:677:9: note: uninitialized use occurs here > return ret; > ^~~ > drivers/nvme/host/ioctl.c:674:2: note: remove the 'if' if its condition is always true > if (ns) > ^~~~~~~ > drivers/nvme/host/ioctl.c:672:9: note: initialize the variable 'ret' to silence this warning > int ret; > ^ > = 0 > 1 error generated. > > Initialize ret to zero so that it cannot be used uninitialized. > > Fixes: 271ee3df5cca ("nvme: wire-up uring-cmd support for io-passthru on char-device.") > Link: https://github.com/ClangBuiltLinux/linux/issues/1630 > Reported-by: kernel test robot > Signed-off-by: Nathan Chancellor > --- > > Or alternatively, remove the 'if (ns)' if ns can never be NULL; I tried > going down the rabbit hole to see if that is possible but I got a little > lost :^) > > drivers/nvme/host/ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c > index 9db88f2c15f8..3ad5285c1f96 100644 > --- a/drivers/nvme/host/ioctl.c > +++ b/drivers/nvme/host/ioctl.c > @@ -669,7 +669,7 @@ int nvme_ns_head_chr_uring_cmd(struct io_uring_cmd *ioucmd, > struct nvme_ns_head *head = container_of(cdev, struct nvme_ns_head, cdev); > int srcu_idx = srcu_read_lock(&head->srcu); > struct nvme_ns *ns = nvme_find_path(head); > - int ret; > + int ret = 0; > > if (ns) > ret = nvme_ns_uring_cmd(ns, ioucmd, issue_flags); > > base-commit: 002b149a51a53facaf26d7c6f2c1fe718673683c > -- > 2.36.0 >