From: Mark Brown <broonie@kernel.org>
To: Hui Tang <tanghui20@huawei.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
ryan.lee.analog@gmail.com, ricardw@axis.com, steve@sk2.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration
Date: Wed, 11 May 2022 13:06:05 +0100 [thread overview]
Message-ID: <YnumrRUSkVCPONdl@sirena.org.uk> (raw)
In-Reply-To: <20220511012348.94288-2-tanghui20@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]
On Wed, May 11, 2022 at 09:23:47AM +0800, Hui Tang wrote:
> devm_regulator_get_optional
> sound/soc/codecs/max98396.c:1556:23: error: ‘GPIOD_OUT_HIGH’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
> "reset", GPIOD_OUT_HIGH);
> ^~~~~~~~~~~~~~
> GPIOF_INIT_HIGH
> sound/soc/codecs/max98396.c:1556:23: note: each undeclared identifier is reported only once for each function it appears in
> sound/soc/codecs/max98396.c:1565:3: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(max98396->reset_gpio, 0);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> gpio_set_value_cansleep
> cc1: all warnings being treated as errors
>
> Add depend on GPIOLIB for 'config SND_SOC_MAX98396'
No, these issues are missing headers not dependencies. In general
gpiolib stubs out so drivers can optionally use GPIO functionality.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-11 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 1:23 [PATCH -next 0/2] ASoC: codecs: Fix build error Hui Tang
2022-05-11 1:23 ` [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration Hui Tang
2022-05-11 12:06 ` Mark Brown [this message]
2022-05-12 4:46 ` Hui Tang
2022-05-11 1:23 ` [PATCH -next 2/2] ASoC: tlv320adc3xxx: " Hui Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnumrRUSkVCPONdl@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ricardw@axis.com \
--cc=ryan.lee.analog@gmail.com \
--cc=steve@sk2.org \
--cc=tanghui20@huawei.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome