From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B261C433EF for ; Wed, 11 May 2022 16:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344753AbiEKQ3I (ORCPT ); Wed, 11 May 2022 12:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344739AbiEKQ3B (ORCPT ); Wed, 11 May 2022 12:29:01 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968C32380C9 for ; Wed, 11 May 2022 09:28:59 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id bs17so2710562qkb.0 for ; Wed, 11 May 2022 09:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Vjtbfzb3XfQBK49vkLU2ME+zLfRrW3PO/4LCqkSQxEo=; b=4rjytAOgIXa9oPL4+JvWFQPgZx54vdMfMIxW8eljWagpDYXPTR81+XelntW9epHwlY DPldjGntjh0a7rjeBqYQVVoujjL/MVQo0nqpIkvAXLC4NlYfuPZdMHZOpF6tz7nxW5x0 UbHP9qf1gRsOxHo/D6Xrwrt3Q1NPgnfJR50weL9kafzWEeHl1RdJeCc220fvKfdufkVk qCmDi88pFnxUC9Hy9C85YGx0KIpbiun+O79f7ude563WJnH2cUkwsB4uCDnUwW3xtpbR zIIuXu9o6qjwbfRwtpqi7ZvCHEdEjbASF/jD9PiRkM5GKbJ0F/ZmqKvgO2zwKVfDmVEt xQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Vjtbfzb3XfQBK49vkLU2ME+zLfRrW3PO/4LCqkSQxEo=; b=HctrZjmMthQDP19sh9P8wsj6qnpEM/t5c6XwnPbTgSwOvjNhIqL2zV5tMsJqIBQz98 wtw7VLNs5s2qWaJB5+1FIpstd9ADJvGktBuZdts1zV8vOBA0+tQQuI8T5O2qRPrhr5Pk rBLhW3w/Rs5WxJO8aZNxuh9MNdhm+sBnn/oQfZVdKnkJPlQRMnBRS+nj/063fbjmGGBc XPBsWdSb7gT8m1xWelyPMr0DFJ8i00rzflxL2j2d8Cl/GT1sl7XDbB4akgN5PqB0f1Lb KRrkVghhgkuU++al+inS30t7RVpttHhUAY1S1FlKNgzcx67DOy2fzLtMwkycPkg3Zh/e 9ijw== X-Gm-Message-State: AOAM532jeMCXF10YP0EFFiA5RW6WpdmUX6YqgB9MRVd58gYoFUpOOHLL KWweEzky1PHQ5jyF8TMVr88O9w== X-Google-Smtp-Source: ABdhPJxft2gzXlXl71SNi+1b64jFQbBGf7Iu8X2dSHgjCzwPpZHsDPkpt95dPvlqSuT8vGr0Dc2BFg== X-Received: by 2002:a05:620a:28ca:b0:6a0:a0a9:b2e6 with SMTP id l10-20020a05620a28ca00b006a0a0a9b2e6mr9828094qkp.638.1652286538773; Wed, 11 May 2022 09:28:58 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:14fe]) by smtp.gmail.com with ESMTPSA id cb25-20020a05622a1f9900b002f39b99f6b0sm1461209qtb.74.2022.05.11.09.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 09:28:58 -0700 (PDT) Date: Wed, 11 May 2022 12:28:57 -0400 From: Johannes Weiner To: Andrew Morton Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , Minchan Kim , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 3/6] mm: Kconfig: group swap, slab, hotplug and thp options into submenus Message-ID: References: <20220510152847.230957-1-hannes@cmpxchg.org> <20220510152847.230957-4-hannes@cmpxchg.org> <20220510154037.c7916ee9d7de90eedd12f92c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 11:22:59AM -0400, Johannes Weiner wrote: > On Tue, May 10, 2022 at 03:40:37PM -0700, Andrew Morton wrote: > > On Tue, 10 May 2022 11:28:44 -0400 Johannes Weiner wrote: > > > > > There are several clusters of related config options spread throughout > > > the mostly flat MM submenu. Group them together and put specialization > > > options into further subdirectories to make the MM submenu a bit more > > > organized and easier to navigate. > > > > Causes > > > > hp2:/usr/src/25> make allnoconfig > > My bad. I'll respin those on top of the others and add allnoconfig > builds to my testing routine. Thanks. Actually, this is rather straight-forward to fix in place. This delta for 3/6 takes care of both warnings: --- >From 2b5fcaed2714584b40c7d7f76bdda250aa94b48f Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Wed, 11 May 2022 12:12:37 -0400 Subject: [PATCH] mm: Kconfig: group swap, slab, hotplug and thp options into submenus fix WARNING: unmet direct dependencies detected for ARCH_WANT_GENERAL_HUGETLB Depends on [n]: TRANSPARENT_HUGEPAGE [=n] Selected by [y]: - X86 [=y] WARNING: unmet direct dependencies detected for ARCH_WANTS_THP_SWAP Depends on [n]: TRANSPARENT_HUGEPAGE [=n] Selected by [y]: - X86 [=y] && X86_64 [=y] The ARCH_WANT* symbols are selected by the arch to communicate requests to THP if enabled. Those mustn't be inside the 'if THP' block for user-visible THP options of course. Move them back out. Reported-by: Andrew Morton Signed-off-by: Johannes Weiner --- mm/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index 2c5935a28edf..c2f4a547ab00 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -692,6 +692,12 @@ config NOMMU_INITIAL_TRIM_EXCESS See Documentation/admin-guide/mm/nommu-mmap.rst for more information. +config ARCH_WANT_GENERAL_HUGETLB + bool + +config ARCH_WANTS_THP_SWAP + def_bool n + menuconfig TRANSPARENT_HUGEPAGE bool "Transparent Hugepage Support" depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE && !PREEMPT_RT @@ -733,12 +739,6 @@ choice benefit. endchoice -config ARCH_WANT_GENERAL_HUGETLB - bool - -config ARCH_WANTS_THP_SWAP - def_bool n - config THP_SWAP def_bool y depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP -- 2.35.3