From: Mark Brown <broonie@kernel.org>
To: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: linux-amarula@amarulasolutions.com, linuxfancy@googlegroups.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: max98088: add support for reg_4a_cfg_bypass reg
Date: Thu, 12 May 2022 12:19:03 +0100 [thread overview]
Message-ID: <YnztJxdSFau6SYC5@sirena.org.uk> (raw)
In-Reply-To: <20220512110959.GF649073@tom-ThinkPad-T14s-Gen-2i>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Thu, May 12, 2022 at 01:09:59PM +0200, Tommaso Merciai wrote:
> On Thu, May 12, 2022 at 11:53:07AM +0100, Mark Brown wrote:
> > On Thu, May 12, 2022 at 12:46:42PM +0200, Tommaso Merciai wrote:
> > > On Thu, May 12, 2022 at 11:12:02AM +0100, Mark Brown wrote:
> > > > These look like they should be DAPM controls since they're controlling
> > > > audio routing but they're being added as regular controls.
> > > Sorry again. You suggest to create a new structure for these entries,
> > > for example:
> > If that's how they fit into the routing for the device, yes - you'd need
> > to define the bypass mixer as well and set up appropraite routes.
> I added this reg as regular controls because this reg is pretty generic
> as you can see this controll bypass of some output, not all.
> What do you think about?
That sounds exactly like a DAPM control, please make them DAPM controls.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-12 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:43 Tommaso Merciai
2022-05-12 10:12 ` Mark Brown
2022-05-12 10:31 ` Tommaso Merciai
2022-05-12 10:46 ` Tommaso Merciai
2022-05-12 10:53 ` Mark Brown
2022-05-12 11:09 ` Tommaso Merciai
2022-05-12 11:19 ` Mark Brown [this message]
2022-05-12 11:27 ` Tommaso Merciai
2022-05-13 15:20 ` Tommaso Merciai
2022-05-16 11:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnztJxdSFau6SYC5@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®