From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF37C433EF for ; Thu, 26 May 2022 18:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348670AbiEZS4I (ORCPT ); Thu, 26 May 2022 14:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348649AbiEZS4D (ORCPT ); Thu, 26 May 2022 14:56:03 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94BD2CC155 for ; Thu, 26 May 2022 11:56:01 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id y189so2395835pfy.10 for ; Thu, 26 May 2022 11:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C23ku60u5EbcBtHDM0AvRYZ9fyGdZC0fsc/OWH0Q2Bo=; b=CzDVt5+0oQ4YdZ25DftcUtcOo9puptREsJGh6kStUtHLsiG3a51UKOFcBCQWGAHz8L LsewvqTAm4PAJUSPfIu1urJRNcxxW3Z3M63Caa0SOzfZcC9qJtrmmL5TjVj2Bpp2oaLE l0d771pItRmXXUKBQWqym60FEuEeQHD6iI4UR2HHqDLIsQ8UdhKAR8db2Arg8Yj6S5kS 5e7yumUXd2sjWycHiDgyverKbEfaQeaQdXoyNjtIxBE22rFzXSm2PMxLG7gQ36+DwMws CL6EqB3Di7KUS6Jd8CaW9IeSdzfqvK6+U8JUTLEKaN8Tq0RM1+jmMfyYSBko6lg/szMh Yr4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=C23ku60u5EbcBtHDM0AvRYZ9fyGdZC0fsc/OWH0Q2Bo=; b=6bj7vlA+j0Fw93mpmHr9cm8gM4fkpwzFhgQ4Wzd5gqQFDCWZtpRHpt+43KJL33YdSa ChRvDvk28+dKnswN89Qa9sME5vtWI4zMTqSvA1r+DlIQs2oMHbrvaH1JsN0WoJXuY+/r DJ4IN0COa8spQVmI/t5eIvWhvZ7Yq9yLQ6YOn9dcOfFiEVpkK+L8btdiLzVUnB/KQ865 VPqDt157fheYSyQTIzrTL3U3UNuMH6vh8IBw4A6asu+HXDnABoYGL8rQvuQIj2WBLw59 AdteS0fApFg+xgbcwkwDCzsK8V1rDXwkWKN6Vy3HdTvfS/JBTsSzek+PuxrpCnTafQk6 rnfQ== X-Gm-Message-State: AOAM532y+jcH48xaDijLG9dHiIp97g9GaAZiXRwxvTIMHCrUqRT3VkGP q8nhhAYTeZ7AVCr7NBIbayYeJ0mPLeU= X-Google-Smtp-Source: ABdhPJxZMhMAjhxQZZDv6TJ/bk+5+JOPLY0CGxLMkTHmSiZzWwIMhhfaXuT0C2q9BLRWk+Lauv9guA== X-Received: by 2002:a63:d04f:0:b0:3f2:76be:bf2e with SMTP id s15-20020a63d04f000000b003f276bebf2emr33624888pgi.15.1653591360823; Thu, 26 May 2022 11:56:00 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:aafd]) by smtp.gmail.com with ESMTPSA id q21-20020aa79615000000b0050dc76281ecsm1857273pfg.198.2022.05.26.11.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 11:56:00 -0700 (PDT) Sender: Tejun Heo Date: Thu, 26 May 2022 08:55:58 -1000 From: Tejun Heo To: Steven Rostedt Cc: Wonhyuk Yang , Ingo Molnar , Baik Song An , Hong Yeon Kim , Taeung Song , linuxgeek@linuxgeek.io, linux-kernel@vger.kernel.org Subject: Re: [PATCH] workqueue: Fix type of cpu in trace event Message-ID: References: <20220504023204.598531-1-vvghjk1234@gmail.com> <20220524162912.0133006b@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524162912.0133006b@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2022 at 04:29:12PM -0400, Steven Rostedt wrote: > On Wed, 4 May 2022 11:32:03 +0900 > Wonhyuk Yang wrote: > > > The trace event "workqueue_queue_work" use unsigned int type for > > req_cpu, cpu. This casue confusing cpu number like below log. > > > > $ cat /sys/kernel/debug/tracing/trace > > cat-317 [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295 > > > > So, change unsigned type to signed type in the trace event. After > > applying this patch, cpu number will be printed as -1 instead of > > 4294967295 as folllows. > > > > I was going through my backlog of pending patches and came across this. > Note, that trace events are maintained by the subsystem they belong to. > This change is for workqueues, not tracing (as your subject correctly > states). > > I Cc'd Tejun here as he maintains this code. I'll apply it to the wq tree once rc1 drops. Thanks. -- tejun