From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE80C433EF for ; Mon, 16 May 2022 06:47:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240437AbiEPGrz (ORCPT ); Mon, 16 May 2022 02:47:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238823AbiEPGrt (ORCPT ); Mon, 16 May 2022 02:47:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CE0DF5D for ; Sun, 15 May 2022 23:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HXtrLe4wM5KnGNLV8EoRoh8NQPYMk6Ja6GmCeJwbR1o=; b=pm9p47qiR0Z1/We4vfX2K/b5yy i90lk9fZff/yQaULCXj3baGA1FhA816A83ADVFJ+j8Hh9jUIOM8G9q2vpgu0IsM43UkYqubvOlsiC +O8aLGDzPkALwrSObhkMaZyaEpq07F3vvDWA1AePb/MSfBCJmvuRSzmtuMWvB9TpKYQsNdp4sGxQ0 fpNkuZe5i4LVeJgWooKNtNeY/7PsQ5dYA/FOinfdi6PBAZl8kIQGxDP6ih9P6zYw8iIKlsVH6uCG/ gUNTFzoC+PeNgo/c9o+OhyKlUTtgZDYZIGlwIX9L5h4JXT26WnzEEJOqikv1S3IJJ+biLWWnhYRhw KgyLK0CA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUWB-006FNR-3B; Mon, 16 May 2022 06:47:47 +0000 Date: Sun, 15 May 2022 23:47:47 -0700 From: Christoph Hellwig To: Greentime Hu Cc: palmer@dabbelt.com, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu Subject: Re: [PATCH v10 05/16] riscv: Add has_vector/riscv_vsize to save vector features. Message-ID: References: <221f72a2ee62cd5350edb5d6a7e8ebb17a7bc321.1652257230.git.greentime.hu@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <221f72a2ee62cd5350edb5d6a7e8ebb17a7bc321.1652257230.git.greentime.hu@sifive.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 08:31:15AM +0000, Greentime Hu wrote: > +#ifdef CONFIG_VECTOR > +#include > +EXPORT_SYMBOL(rvv_enable); > +EXPORT_SYMBOL(rvv_disable); > +#endif As far as I can tell these are not used by any modular code, just by the later added kernel mode vector enable helpers. Even if they were used this would need to be EXPORT_SYMBOL_GPL. > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2012 Regents of the University of California > + * Copyright (C) 2017 SiFive > + * Copyright (C) 2019 Alibaba Group Holding Limited > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation, version 2. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ No need for all the GPL boilerplate text when you have an SPDX tag.