mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tomasz Figa <tfiga@chromium.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Yunke Cao <yunkec@google.com>
Subject: Re: [PATCH 1/4] media: uvcvideo: Add missing value for power_line_frequency
Date: Thu, 19 May 2022 20:18:09 +0300	[thread overview]
Message-ID: <YoZ70Ssf4PTq3OaL@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220519154100.333091-2-ribalda@chromium.org>

Hi Ricardo,

Thank you for the patch.

On Thu, May 19, 2022 at 05:40:56PM +0200, Ricardo Ribalda wrote:
> UVC 1.5 class defines 4 values for this control on:
> 4.2.2.3.6 Power Line Frequency Control

But UVC 1.1 doesn't. This thus has to be conditioned on the UVC version.

> Add the missing value.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/usb/uvc/uvc_ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> index b4f6edf968bc..13cad4aa7573 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -366,6 +366,7 @@ static const struct uvc_menu_info power_line_frequency_controls[] = {
>  	{ 0, "Disabled" },
>  	{ 1, "50 Hz" },
>  	{ 2, "60 Hz" },
> +	{ 3, "Auto" },
>  };
>  
>  static const struct uvc_menu_info exposure_auto_controls[] = {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-05-19 17:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 15:40 [PATCH 0/4] uvcvideo: Fix handling of power_line_frequency Ricardo Ribalda
2022-05-19 15:40 ` [PATCH 1/4] media: uvcvideo: Add missing value for power_line_frequency Ricardo Ribalda
2022-05-19 17:18   ` Laurent Pinchart [this message]
2022-05-19 15:40 ` [PATCH 2/4] media: uvcvideo: Add UVC_QUIRK_LIMITED_POWERLINE Ricardo Ribalda
2022-05-19 15:40 ` [PATCH 3/4] media: uvcvideo: Add LIMITED_POWERLINE quirks for Quanta UVC Webcam Ricardo Ribalda
2022-05-19 15:40 ` [PATCH 4/4] media: uvcvideo: Add LIMITED_POWERLINE quirks for Chicony Easycamera Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoZ70Ssf4PTq3OaL@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ribalda@chromium.org \
    --cc=senozhatsky@chromium.org \
    --cc=tfiga@chromium.org \
    --cc=yunkec@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®