From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6790CC433EF for ; Mon, 23 May 2022 13:55:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236690AbiEWNzW (ORCPT ); Mon, 23 May 2022 09:55:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236686AbiEWNzT (ORCPT ); Mon, 23 May 2022 09:55:19 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD5FE56F92 for ; Mon, 23 May 2022 06:55:16 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id n10so14129333pjh.5 for ; Mon, 23 May 2022 06:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Df9yWQ/aDxzNckvtabHN6S/25VXwYOsM+nyYbdaI3a8=; b=TzTbXf5jrW5oQ4yIsnoZCjia8f/YM/jmgfc1tLNqZmzCb3k08ZDczecDygA0fXzxW0 M81MuFj8NK6DtCT/7OVTIJAv3BhESb+ZGlV+g6JnG+cYwI4CMLm02QiKYbzV39WLLSMS komvx0Xcb0OjEcfD56VP8GFPwyRc8+XD62mjfdTjYLgCGwqfkwDFeTyxa0gvcwRln5V/ eppJDWhh1gIYIIsgZb6SvwT1JFJc8Rc2PSnfcYkaYqyCR0LGr7wqnJA8xusq60qOrKuG qGuAxRsk7r+MPmY10Dyd8BT8HZLGxWoTa7CzLg8N/e+uS1IVHCPP3SOQTgQY7OVwOhG9 40mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Df9yWQ/aDxzNckvtabHN6S/25VXwYOsM+nyYbdaI3a8=; b=4iyB3pQWxv5h8UGspMjyVHWCmNRZ3Ks9V5TJEFZgzmYII7qdQlB5XLTszvBm6CyfkU +0fiAF1oeSwPHtDaDd9wF8n+rrTArkYGALjK3euLtBaL5zWMZguGrb+l8VxJrQhj8vAv 6glw4VoBxXU2QgK0VbN9meuTAIgCKZgKX0ZKxnAz46XXHspmd5GlxBk/KfIiQff2MC6A IbQamAFof7mErKIvnqR20thj/56tFik20hRuYxiD7kZJ/WVFYDmDyHeRuiw51J/GWM8b 0+UNdS+cohZwjfqerpQunVH86m3wWyffw0YVim89bzfKh7uiD4yI60ZRYXIRQTKDCHdH GIqw== X-Gm-Message-State: AOAM530Egf4LNP2rfp+sDVO3uEDB1jJMytgwuYiPq/EZn0oajD/RgaSw ljrinIP8hLZXZCknwEsTvFQ0bQ== X-Google-Smtp-Source: ABdhPJzTAKPyvsoV7ZaiJUcH3STTBACV6avvux7V/4Wgew6Anu+8+y7upkEqa6ojZ1VZGLBk9Poqrg== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr23014244plq.106.1653314116404; Mon, 23 May 2022 06:55:16 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:2c28:f36b:423b:6bc6]) by smtp.gmail.com with ESMTPSA id a15-20020a170902eccf00b0016170bb6528sm5211384plh.113.2022.05.23.06.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 06:55:15 -0700 (PDT) Date: Mon, 23 May 2022 21:55:10 +0800 From: Muchun Song To: Christophe JAILLET Cc: dan.carpenter@oracle.com, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Tejun Heo , Zefan Li , Shuah Khan , David Vernet , Andrew Morton , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] cgroup: Fix an error handling path in alloc_pagecache_max_30M() Message-ID: References: <628312312eb40e0e39463a2c06415fde5295c716.1653229120.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <628312312eb40e0e39463a2c06415fde5295c716.1653229120.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 22, 2022 at 04:18:51PM +0200, Christophe JAILLET wrote: > If the first goto is taken, 'fd' is not opened yet (and is un-initialized). > So a direct return is safer. > > Fixes: c1a31a2f7a9c ("cgroup: fix racy check in alloc_pagecache_max_30M() helper function") > Signed-off-by: Christophe JAILLET Acked-by: Muchun Song Thanks.