From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D580FC433F5 for ; Mon, 23 May 2022 19:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbiEWTZn (ORCPT ); Mon, 23 May 2022 15:25:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbiEWTZO (ORCPT ); Mon, 23 May 2022 15:25:14 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42313174911 for ; Mon, 23 May 2022 12:04:19 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id 202so7495969pfu.0 for ; Mon, 23 May 2022 12:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ry0605dl+YcGvkJKzAEQ3WcZNm1x8lAWLbnXr+W+zTI=; b=kKZDJvitoPDX7n0OSbQVwarphKOVShdw4sHCRu1Az9GlaT12ZJlQAGoG4txmt1fjI3 OaOMwlkfS4qtGPOkaZnqOlRk7x8goZ+RVanUTJkEvDw5lS2dmzZe3CPN7MBSj3s1BHRo qHeAn08E7v9t6nzCvD5ZYajIKXpiQ9efwrU2eraaZmQySDCSV49WZyb/lXlg0kfoGe8s kXJmdAnn3a3cuF01MPxJLKZx8daZu7kTLsPkjPYMvdUsihJeiOS+MKYywUw33pVHyDN1 U671hNMKSeiz8vGRiRt4TRJT9mJcGQ4+J4p22kc8enymXkJ625hy7Fa9lYFArm+RuURH LxGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Ry0605dl+YcGvkJKzAEQ3WcZNm1x8lAWLbnXr+W+zTI=; b=7gt2GK4XYS5fq78EjBYXdINEs1xaAOKUI60ylkkq/yXv903lRG2yKlLhV3740i/bem AMSbD/0oa8IPC7aaLG4rGtHXb0xRUhjQZbY7dG0IQo5FFiaXKfKbNyncSrbA1V/4Nyeo mqv6HpXRcDfRo5WoLqMhPrKzOnsTudM5j9Q6NgNy5okmrvFIPfq+czlLCeXtbkyJoxPl pW2eAYCnEgkeumleMSPZMBiQpyOF7rAv3Oa+ua1bMQ0J+NKmo/vpEInW8sSyYqUlr5ot 0zv18jJMZyB7XhKd1Ev5+qZQl3TsccXymITZDzj0r4ptJ5e8oS/lQko2c5axeE+dN//Y PTvA== X-Gm-Message-State: AOAM533sLbc9yaVsGiaiX4wfGDdm5R9CIULMdVw6dp/Sq86zj6CcMPst Sab1TuAxhegjeeWdZ22byBnzLWQ8V54= X-Google-Smtp-Source: ABdhPJxndU8LKAzlicd0O4iMleYxPzC4VW6YIK4yZJChhqi60vvIqWO2ra0TlmBZg1vxwxy0CET/nA== X-Received: by 2002:a65:42cc:0:b0:3a9:f71f:33f9 with SMTP id l12-20020a6542cc000000b003a9f71f33f9mr21303921pgp.391.1653332658580; Mon, 23 May 2022 12:04:18 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:aafd]) by smtp.gmail.com with ESMTPSA id g25-20020a639f19000000b003f5eb31fc4bsm4969105pge.11.2022.05.23.12.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 12:04:17 -0700 (PDT) Sender: Tejun Heo Date: Mon, 23 May 2022 09:04:16 -1000 From: Tejun Heo To: Tetsuo Handa Cc: LKML , Andrew Morton Subject: Re: [PATCH v3] workqueue: Wrap flush_workqueue() using a macro Message-ID: References: <7b2fecdb-59ae-2c54-5a5b-774ef7054d1b@I-love.SAKURA.ne.jp> <1c1b272b-239c-e1d1-84de-47d02feb911e@I-love.SAKURA.ne.jp> <5f417d30-34a7-8da1-0ad5-33bd750582c7@I-love.SAKURA.ne.jp> <1a1634ac-db0e-a44c-b286-a3aba55ad695@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2022 at 08:37:19PM +0900, Tetsuo Handa wrote: > +/* > + * Detect attempt to flush system-wide workqueues at compile time when possible. > + * > + * Always warn, for there is no in-tree flush_workqueue(system_*_wq) user. > + */ > +#define flush_workqueue(wq) \ > +do { \ > + if ((__builtin_constant_p(&(wq) == &system_wq) && \ > + &(wq) == &system_wq) || \ > + (__builtin_constant_p(&(wq) == &system_highpri_wq) && \ > + &(wq) == &system_highpri_wq) || \ > + (__builtin_constant_p(&(wq) == &system_long_wq) && \ > + &(wq) == &system_long_wq) || \ > + (__builtin_constant_p(&(wq) == &system_unbound_wq) && \ > + &(wq) == &system_unbound_wq) || \ > + (__builtin_constant_p(&(wq) == &system_freezable_wq) && \ > + &(wq) == &system_freezable_wq) || \ > + (__builtin_constant_p(&(wq) == &system_power_efficient_wq) && \ > + &(wq) == &system_power_efficient_wq) || \ > + (__builtin_constant_p(&(wq) == &system_freezable_power_efficient_wq) && \ > + &(wq) == &system_freezable_power_efficient_wq)) \ > + __warn_flushing_systemwide_wq(); \ > + flush_workqueue(wq); \ > +} while (0) Please just rename the backend function. Thanks. -- tejun