From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DAEC433EF for ; Mon, 6 Jun 2022 06:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbiFFGFZ (ORCPT ); Mon, 6 Jun 2022 02:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbiFFGFV (ORCPT ); Mon, 6 Jun 2022 02:05:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 684211CB10 for ; Sun, 5 Jun 2022 23:05:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14EA5B81088 for ; Mon, 6 Jun 2022 06:05:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D351C385A9; Mon, 6 Jun 2022 06:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654495516; bh=zwJfnS/wE1sDCszcl+CSabMelPPt/DfmOcBmAm19SNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IBfBqXmjcvTVkXHY4YUlGomdCIbCsWjiXKhvfIPP4l0umm3z4dhXYaw9aXEllFyBM gHgkIKo642jP5ZmpGHm1qff5FpLMqEYamCzxmKIEDG+s6ifgK9HMIlxyDl4bhP63VJ sswFJC9/J3HQUiDlsP5t2GD08acfEjgdb9Ii6CgU= Date: Mon, 6 Jun 2022 08:05:14 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: r8188eu: remove rtw_usleep_os Message-ID: References: <20220602194807.281115-1-martin@kaiser.cx> <20220602194807.281115-3-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220602194807.281115-3-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2022 at 09:48:06PM +0200, Martin Kaiser wrote: > Remove the rtw_usleep_os helper function. There are only two callers, both > of which call rtw_usleep_os(100). > > The original code would translate rtw_usleep_os(100) into msleep(1). Using > msleep for < 20ms is not recommended. Replace the msleep calls with > usleep_range, based on the explanations in > Documentation/timers/timers-howto.rst. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/core/rtw_pwrctrl.c | 2 +- > drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +- > drivers/staging/r8188eu/include/osdep_service.h | 2 -- > drivers/staging/r8188eu/os_dep/osdep_service.c | 8 -------- > 4 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_pwrctrl.c b/drivers/staging/r8188eu/core/rtw_pwrctrl.c > index 7b816b824947..11fd05633529 100644 > --- a/drivers/staging/r8188eu/core/rtw_pwrctrl.c > +++ b/drivers/staging/r8188eu/core/rtw_pwrctrl.c > @@ -266,7 +266,7 @@ static s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) > err = -1; > break; > } > - rtw_usleep_os(100); > + usleep_range(1000, 1200); How do you know this is the proper range? > } > > return err; > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > index e17375a74f17..1aa7d01b67b1 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > @@ -208,7 +208,7 @@ static void efuse_read_phymap_from_txpktbuf( > rtw_write8(adapter, REG_TXPKTBUF_DBG, 0); > timeout = jiffies + msecs_to_jiffies(1000); > while (!rtw_read8(adapter, REG_TXPKTBUF_DBG) && time_before(jiffies, timeout)) > - rtw_usleep_os(100); > + usleep_range(1000, 1200); Same here, how do you know this is the correct range? I would just use msleep as needed and later change to a range if you have figured out that is allowed. thanks, greg k-h