From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A5BC43334 for ; Mon, 6 Jun 2022 10:37:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234108AbiFFKhy (ORCPT ); Mon, 6 Jun 2022 06:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234082AbiFFKhw (ORCPT ); Mon, 6 Jun 2022 06:37:52 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67E4B12AD5 for ; Mon, 6 Jun 2022 03:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654511870; x=1686047870; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qQ/9qGTYF8uA8ohG6pw+Jukr0gB7zxV+urlvatt/wBQ=; b=YCtJbTlQ24rwS39skT52geFP3fPkLQRPD/SXZ2o8FpYbd93rYyheMYBL WK+uzou7aV5ggEtRar3qo1VdmvXDeilDw9qUWynNK8+9Yew+bwNVkg31A xQR9x5ZI0ygCrPkmE2NlK5mnOSLQ9wwRW5DEmauhc3TLj8jNEr7RS+eks XLUJNzxkF1XnjBQoTemMHptrFlPxhJBRo6SAkbVvlLIxvoTlXbhV/y8Ny EqQ8SlQSQM09nZY14DMjwv+Z876kCoCJPN7UUZZXUzFF+UpxO1zUGu9eA 76cPYwDfwMh3FdowguFqt7pNVFpIm3lbixxuex5Jg5CCQstDff14JWh6D A==; X-IronPort-AV: E=McAfee;i="6400,9594,10369"; a="275423164" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="275423164" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 03:37:48 -0700 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="532080265" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 03:37:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nyA7B-000UaB-V7; Mon, 06 Jun 2022 13:37:41 +0300 Date: Mon, 6 Jun 2022 13:37:41 +0300 From: Andy Shevchenko To: Sander Vanheule Cc: Peter Zijlstra , Yury Norov , Andrew Morton , Valentin Schneider , Thomas Gleixner , Greg Kroah-Hartman , Marco Elver , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] cpumask: Update cpumask_next_wrap() signature Message-ID: References: <52c0f58d879f9f12fc2a9230ee08da219dc5298c.1654410109.git.sander@svanheule.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52c0f58d879f9f12fc2a9230ee08da219dc5298c.1654410109.git.sander@svanheule.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 05, 2022 at 08:22:41AM +0200, Sander Vanheule wrote: > The extern specifier is not needed for this declaration, so drop it. The > function also depends only on the input parameters, and has no side > effects, so it can be marked __pure like other functions in cpumask.h Missed period. Reviewed-by: Andy Shevchenko > Signed-off-by: Sander Vanheule > --- > include/linux/cpumask.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h > index 7ccddbc27ac3..f37ce00741a3 100644 > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -210,7 +210,7 @@ int cpumask_any_distribute(const struct cpumask *srcp); > (cpu) = cpumask_next_zero((cpu), (mask)), \ > (cpu) < nr_cpu_ids;) > > -extern int cpumask_next_wrap(int n, const struct cpumask *mask, int start, bool wrap); > +int __pure cpumask_next_wrap(int n, const struct cpumask *mask, int start, bool wrap); > > /** > * for_each_cpu_wrap - iterate over every cpu in a mask, starting at a specified location > -- > 2.36.1 > -- With Best Regards, Andy Shevchenko