From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH] random: defer use of bootloader randomness to random_init()
Date: Tue, 7 Jun 2022 16:48:14 +0200 [thread overview]
Message-ID: <Yp9lLkYXCo9BZxpk@zx2c4.com> (raw)
In-Reply-To: <CAMj1kXH4ifsytLNpaVTHAumadMjj8rNEZbsn-8t=hH51ucG11A@mail.gmail.com>
Hi Ard,
On Tue, Jun 07, 2022 at 04:19:26PM +0200, Ard Biesheuvel wrote:
> #include <stdio.h>
> #include <stdlib.h>
> #include <sys/random.h>
>
> static unsigned char buf[16];
>
> int main(void)
> {
> for (int i = 0; i < 1000000; i++) {
> if (getrandom(buf, sizeof(buf),
> GRND_RANDOM | GRND_NONBLOCK) < sizeof(buf)) {
> fprintf(stderr, "getrandom() error!\n");
> exit(-1);
> }
> }
> return 0;
> }
I'm actually more worried about the random input flow than the random
output flow and branch misprediction. But more generally, I'd just like
to keep that code as cold as possible after crng init. It's code that's
only used in that one phase and then never again. It can be entirely
disabled.
Anyway, we've got a few solutions now to pick from on the random.c side
of things. I'm going to investigate the arm32 situation next. And then
we'll see what it all looks like.
Jason
next prev parent reply other threads:[~2022-06-07 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 11:15 Jason A. Donenfeld
2022-06-07 11:22 ` Jason A. Donenfeld
2022-06-07 11:32 ` [PATCH v2] random: defer crediting " Jason A. Donenfeld
2022-06-07 12:19 ` Phil Elwell
2022-06-07 12:23 ` Jason A. Donenfeld
2022-06-07 12:44 ` [PATCH v3] " Jason A. Donenfeld
2022-06-07 13:21 ` Phil Elwell
2022-06-07 13:51 ` Jason A. Donenfeld
2022-06-07 14:13 ` Phil Elwell
2022-06-07 11:55 ` [PATCH] random: defer use of " Ard Biesheuvel
2022-06-07 12:04 ` Jason A. Donenfeld
2022-06-07 12:15 ` Ard Biesheuvel
2022-06-07 12:21 ` Jason A. Donenfeld
2022-06-07 14:19 ` Ard Biesheuvel
2022-06-07 14:48 ` Jason A. Donenfeld [this message]
2022-06-07 14:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9lLkYXCo9BZxpk@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=phil@raspberrypi.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®