From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8034AC433EF for ; Fri, 3 Jun 2022 12:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244468AbiFCM7u (ORCPT ); Fri, 3 Jun 2022 08:59:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233094AbiFCM7r (ORCPT ); Fri, 3 Jun 2022 08:59:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CEC831514 for ; Fri, 3 Jun 2022 05:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cLtR22X2YMGBRu4CJqe5w4vOiyDa2dkTADcsreL0J6Y=; b=fro3tgYwYJIMFutExfLTy2/NTc enNFhHBR3bjAlqnjKfkPTxarHHM2BoYPWgwsvy6c5GRj1sKQEw4Dba7t/np1TQF0YM/REBrGPa28X jbBSEuPmGxkO1ruVzQmWkKMvLU0V2TuwhJdXRilN6fAk0zo3ptEDSanCN1R47AsAO4r9ErH6Zktjr 2lZK68C04tg1pXmG+LfJDMR3Hs7dl6Ono6nXbhghfzNVfTsaTjfFk2CpwGwGxcFKrd8uZ6vrHprNa 9NgjQPVxCEoCy02ZQBLuIT3b+7LRWGkIdowBk9lEWqxZqUpW3Z+oHG3d+N+gBWMSRcW6Zd7qv8Ysm YSdyraDw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx6tR-007uOt-KY; Fri, 03 Jun 2022 12:59:09 +0000 Date: Fri, 3 Jun 2022 13:59:09 +0100 From: Matthew Wilcox To: Marek Szyprowski Cc: Hsin-Yi Wang , Phillip Lougher , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] squashfs: implement readahead Message-ID: References: <20220601103922.1338320-1-hsinyi@chromium.org> <20220601103922.1338320-4-hsinyi@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2022 at 02:54:21PM +0200, Marek Szyprowski wrote: > Hi, > > On 01.06.2022 12:39, Hsin-Yi Wang wrote: > > Implement readahead callback for squashfs. It will read datablocks > > which cover pages in readahead request. For a few cases it will > > not mark page as uptodate, including: > > - file end is 0. > > - zero filled blocks. > > - current batch of pages isn't in the same datablock or not enough in a > > datablock. > > - decompressor error. > > Otherwise pages will be marked as uptodate. The unhandled pages will be > > updated by readpage later. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Hsin-Yi Wang > > Reported-by: Matthew Wilcox > > Reported-by: Phillip Lougher > > Reported-by: Xiongwei Song > > --- > > This patch landed recently in linux-next as commit 95f7a26191de > ("squashfs: implement readahead"). I've noticed that it causes serious > issues on my test systems (various ARM 32bit and 64bit based boards). > The easiest way to observe is udev timeout 'waiting for /dev to be fully > populated' and prolonged booting time. I'm using squashfs for deploying > kernel modules via initrd. Reverting aeefca9dfae7 & 95f7a26191deon on > top of the next-20220603 fixes the issue. How large are these files? Just a few kilobytes?