From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH] dt-bindings: phy: make phy-cells description a text
Date: Sun, 19 Jun 2022 14:40:12 +0300 [thread overview]
Message-ID: <Yq8LHN+WGVpXDwiM@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220619113325.21396-1-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
Thank you for the patch.
On Sun, Jun 19, 2022 at 01:33:25PM +0200, Krzysztof Kozlowski wrote:
> The description field is a string, so using YAML inside phy-cells
> description is not actually helpful.
Does it hurt though ? For xlnx,zynqmp-psgtr.yaml I wrote it that way to
prepare for a future where it could be described using a YAML schema
(but such future may never come).
> Make it a proper text.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/phy/mediatek,tphy.yaml | 14 ++++----
> .../bindings/phy/mediatek,xsphy.yaml | 10 +++---
> .../bindings/phy/xlnx,zynqmp-psgtr.yaml | 32 ++++++++-----------
> 3 files changed, 23 insertions(+), 33 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 4b638c1d4221..bd0e4c4915ed 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -154,14 +154,12 @@ patternProperties:
> "#phy-cells":
> const: 1
> description: |
> - The cells contain the following arguments.
> -
> - - description: The PHY type
> - enum:
> - - PHY_TYPE_USB2
> - - PHY_TYPE_USB3
> - - PHY_TYPE_PCIE
> - - PHY_TYPE_SATA
> + The cells contain the following arguments::
> + - The PHY type::
> + - PHY_TYPE_USB2
> + - PHY_TYPE_USB3
> + - PHY_TYPE_PCIE
> + - PHY_TYPE_SATA
>
> nvmem-cells:
> items:
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> index 598fd2b95c29..7262b8e184e2 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> @@ -100,12 +100,10 @@ patternProperties:
> "#phy-cells":
> const: 1
> description: |
> - The cells contain the following arguments.
> -
> - - description: The PHY type
> - enum:
> - - PHY_TYPE_USB2
> - - PHY_TYPE_USB3
> + The cells contain the following arguments::
> + - The PHY type::
> + - PHY_TYPE_USB2
> + - PHY_TYPE_USB3
>
> # The following optional vendor properties are only for debug or HQA test
> mediatek,eye-src:
> diff --git a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> index 79906519c652..7083eddb467c 100644
> --- a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> +++ b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> @@ -18,25 +18,19 @@ properties:
> "#phy-cells":
> const: 4
> description: |
> - The cells contain the following arguments.
> -
> - - description: The GTR lane
> - minimum: 0
> - maximum: 3
> - - description: The PHY type
> - enum:
> - - PHY_TYPE_DP
> - - PHY_TYPE_PCIE
> - - PHY_TYPE_SATA
> - - PHY_TYPE_SGMII
> - - PHY_TYPE_USB3
> - - description: The PHY instance
> - minimum: 0
> - maximum: 1 # for DP, SATA or USB
> - maximum: 3 # for PCIE or SGMII
> - - description: The reference clock number
> - minimum: 0
> - maximum: 3
> + The cells contain the following arguments::
> + - The GTR lane (minimum:: 0, maximum:: 3)
> + - The PHY type::
> + - PHY_TYPE_DP
> + - PHY_TYPE_PCIE
> + - PHY_TYPE_SATA
> + - PHY_TYPE_SGMII
> + - PHY_TYPE_USB3
> + - The PHY instance::
> + minimum:: 0
> + maximum:: 1 # for DP, SATA or USB
> + maximum:: 3 # for PCIE or SGMII
> + - The reference clock number (minimum:: 0, maximum:: 3)
>
> compatible:
> enum:
> --
> 2.34.1
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-06-19 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 11:33 Krzysztof Kozlowski
2022-06-19 11:40 ` Laurent Pinchart [this message]
2022-06-19 11:46 ` Krzysztof Kozlowski
2022-06-19 11:51 ` Laurent Pinchart
2022-06-27 23:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yq8LHN+WGVpXDwiM@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sean.anderson@seco.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®