mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper
Date: Wed, 8 Jun 2022 14:53:28 +0300	[thread overview]
Message-ID: <YqCNuJ3RQX3jIy59@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gmO-BDyurQtG4sU5KLfe2mjs7vm5kpJQoAaxYxF57t3g@mail.gmail.com>

On Wed, Jun 08, 2022 at 01:29:08PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jun 7, 2022 at 10:22 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> I would define it as
> 
> static int match_first(struct device *dev, void *)
> {
>        return 1;
> }
> 
> struct device *device_find_first_child(struct device *parent)
> {
>         return device_find_first_child(parent, NULL, match_first);
> }
> EXPORT_SYMBOL_GPL(device_find_first_child);
> 
> which is not that much more overhead.

With this we actually may simply provide a match function and it will make the
clean ups (like patch 2 in the series) almost the same without introducing a
device core call.

Something like

int device_match_any_for_find(struct device *dev, void *unused)
{
	return 1;
}

As I replied to Greg it's pity we can't use device_match_any()...

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-06-08 11:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 20:20 Andy Shevchenko
2022-06-07 20:20 ` [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach Andy Shevchenko
2022-06-08 11:30   ` Rafael J. Wysocki
2022-06-08 11:36   ` Greg Kroah-Hartman
2022-06-08 11:49     ` Andy Shevchenko
2022-06-08 12:03       ` Greg Kroah-Hartman
2022-06-08 12:23         ` Andy Shevchenko
2022-06-08 11:29 ` [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper Rafael J. Wysocki
2022-06-08 11:53   ` Andy Shevchenko [this message]
2022-06-08 12:04     ` Greg Kroah-Hartman
2022-06-08 12:15       ` Rafael J. Wysocki
2022-06-08 12:23         ` Greg Kroah-Hartman
2022-06-08 13:32           ` Rafael J. Wysocki
2022-06-08 12:19     ` Rafael J. Wysocki
2022-06-08 11:32 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqCNuJ3RQX3jIy59@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®