From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0599DC433EF for ; Fri, 10 Jun 2022 08:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347405AbiFJIRq (ORCPT ); Fri, 10 Jun 2022 04:17:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347393AbiFJIRU (ORCPT ); Fri, 10 Jun 2022 04:17:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E40226557; Fri, 10 Jun 2022 01:17:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B68AB83080; Fri, 10 Jun 2022 08:17:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48450C3411B; Fri, 10 Jun 2022 08:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654849023; bh=IyeUl084OKLUA3ct/9HrNTTAqajQrjHZwP2dAxU/Z/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kAuOpgXOymuZ6MpR8gpXyN5R+sRLj7kzoSs6Tk+e7j4RGG9QTecv8U/pkwbrxB3Yw t+z8QnLOrI9U1WSiP//O5zDTH+Eb6QpAI86RLoCEn2ThvanCsBa+HrYPZcceRiOpiR DAD1KU1I0xniSugVMM4UlGyhF3sAUENpH1c3p3XvymhVeecxNCU03/F2I3GXu8GLHd Xj0Mh+zBwTHn1sFnTb86WmtbaQQsY4ERc+rz5QhKxWid+BfTtNlrt4ePyBpOyvqIde SxGvKh2NMUTuuJ+spzZRvcnvdENNc74ORA+Ib/yZGmD+lyGN9MMhjFbdM4o1rqLqKB oBeZrmTWvrDAQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nzZpC-0007NZ-Pc; Fri, 10 Jun 2022 10:16:58 +0200 Date: Fri, 10 Jun 2022 10:16:58 +0200 From: Johan Hovold To: Dan Carpenter Cc: Jared Kangas , elder@kernel.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [greybus-dev] Re: [PATCH v2] staging: greybus: audio: fix loop cursor use after iteration Message-ID: References: <20220609214517.85661-1-kangas.jd@gmail.com> <20220610080627.GA2146@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610080627.GA2146@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2022 at 11:06:27AM +0300, Dan Carpenter wrote: > On Fri, Jun 10, 2022 at 10:00:03AM +0200, Johan Hovold wrote: > > > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio modules") > > > Cc: stable@vger.kernel.org > > > Reviewed-by: Dan Carpenter > > > Reviewed-by: Johan Hovold > > > Signed-off-by: Jared Kangas > > > --- > > > > > > Changes since v1: > > > * Removed safe list iteration as suggested by Johan Hovold > > > * Updated patch changelog to explain the list iteration change > > > * Added tags to changelog based on feedback (Cc:, Fixes:, Reviewed-by:) > > > > Apparently Greg applied this to staging-next before we had a change to > > look at it. You should have received a notification from Greg when he > > did so. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=80c968a04a381dc0e690960c60ffd6b6aee7e157 > > > > It seems unlikely that this would cause any issues in real life, but > > there's still a chance it will be picked up by the stable team despite > > the lack of a CC stable tag. > > If you want you can always email the stable team to pick up the patch. Yes, of course. But it will be months before this fix hits mainline and I probably won't remember to do so then. I'm pretty sure Sasha's autosel tool will pick it up anyway, though. Johan