From: Mark Brown <broonie@kernel.org>
To: David Fries <David@fries.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spidev_test: Warn when the mode is not the requested mode
Date: Mon, 13 Jun 2022 13:08:58 +0100 [thread overview]
Message-ID: <Yqco2kRAKBJ+fQkf@sirena.org.uk> (raw)
In-Reply-To: <YqbNnSGtWHe/GG7w@spacedout.fries.net>
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Mon, Jun 13, 2022 at 12:39:41AM -0500, David Fries wrote:
> + /* Drivers can reject some mode bits without returning an error.
> + * Read the current value to identify what mode it is in, and if it
> + * differs from the requested mode, warn the user.
> + */
> + if(request != mode)
Please try to follow the kernel coding style - both the if( and the
comment don't.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-13 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 5:39 David Fries
2022-06-13 12:08 ` Mark Brown [this message]
2022-06-13 17:24 ` Mark Brown
2022-06-13 14:35 David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqco2kRAKBJ+fQkf@sirena.org.uk \
--to=broonie@kernel.org \
--cc=David@fries.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®