From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9F4CCA480 for ; Mon, 13 Jun 2022 19:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346167AbiFMTES (ORCPT ); Mon, 13 Jun 2022 15:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347187AbiFMTDH (ORCPT ); Mon, 13 Jun 2022 15:03:07 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89D1DE03B for ; Mon, 13 Jun 2022 09:41:32 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id z17so6217178pff.7 for ; Mon, 13 Jun 2022 09:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O+JocPgmO8WNM4BldK6U8fZVXY76qHP3I087zvG+y48=; b=g3dcbrCKJI/BbBGz+mo9iC7bdjomgr5vnnU7/831GTnPptxXpZ0Ar6CcTaN25QOvqd VAsdBYGvK4fj2dCR/GtP7gk5MDXJxUe9H4SKW30Uie5kQnGHxmL3tf6VBnpblKXgVDQb e6xxWX2ACphUbDcaxSA37nbHlUEGtayXluwu9FTQQro8Hx6X5DIUVMxKAfWtEY2fAwb/ G82hC6TqXFVSb7gUr0NhO1UqgGPh3o+i5E7wTvwoiSEW3Nv9wILVE4/RHShrK9eTAEjF pPa1lyUGuk5yUtCPTyX78U8q4Naumo7gOYM2vdKv+OOMXnWgytloUMxEwimoZn+nlqwV AJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O+JocPgmO8WNM4BldK6U8fZVXY76qHP3I087zvG+y48=; b=cG0TgMkccwxmMduTpzLHTBcXYBD1amDXIZ+8JLHzZx3zNCmV5L5l/Iu4ha+CrWPLWD P6VkoZDqySK2EBJlEbTvGX38NZJiGYHTp7oxS4FA3TMJAbpBw1M1CrD9THffXSPdLKhS npLZm03AuTLO7BVh8OpXroVjHVzek/38FnE/ziDKO+oaV2a3mNaKPH+K2ah1rEnlGtgU TAYcJR11g0k3NAX/e/L9/0DkWYa4oPO36pqUV7mRkGHKrB2tBhW/8Hg6zq6c/VtOXmto tLE3nZ+7//bL1vcH+GeXqnJfTcOeUKqPAgi7VNX7gFmzr7KD5ewdwKHL+xrGXrcfD/2q ZSrg== X-Gm-Message-State: AOAM530O3nmH8XFFAuBymrYesLQ6fWlzRdyczNyBa7Ubc9JHegRgkeg5 yd7au0uKN9noMTzyJ8mWxxRAYw== X-Google-Smtp-Source: ABdhPJyEHkALhnbB6gryb80ttr+wk7GpaS/12VCioSqOpKgG+WeNaPDgSVYurGGS6l1E6JVjQlE9FQ== X-Received: by 2002:a63:1559:0:b0:3f5:fdf7:12e2 with SMTP id 25-20020a631559000000b003f5fdf712e2mr409373pgv.13.1655138491804; Mon, 13 Jun 2022 09:41:31 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id u7-20020a63b547000000b003fc136f9a7dsm5649504pgo.38.2022.06.13.09.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 09:41:31 -0700 (PDT) Date: Mon, 13 Jun 2022 16:41:27 +0000 From: Sean Christopherson To: Anirudh Rayabharam Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ilias Stamatis , Maxim Levitsky , mail@anirudhrb.com, kumarpraveen@linux.microsoft.com, wei.liu@kernel.org, robert.bradford@intel.com, liuwe@microsoft.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: nVMX: Don't expose TSC scaling to L1 when on Hyper-V Message-ID: References: <20220613161611.3567556-1-anrayabh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613161611.3567556-1-anrayabh@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2022, Anirudh Rayabharam wrote: > As per the comments in arch/x86/kvm/vmx/evmcs.h, TSC multiplier field is It's not just the comments, it's also the code. It would be helpful to call out in the changelog that KVM clears unsupported controls via evmcs_sanitize_exec_ctrls() when using eVMCS. > currently not supported in EVMCS. As a result, there is no TSC scaling > support when KVM is running on Hyper-V i.e. kvm_has_tsc_control is > false. > > However, in nested_vmx_setup_ctls_msrs(), TSC scaling is exposed to L1. > When L1 tries to launch an L2 guest, vmcs12 has TSC scaling enabled. > This propagates to vmcs02. But KVM doesn't set the TSC multiplier value > because kvm_has_tsc_control is false. Due to this, VM entry for L2 guest > fails. (VM entry fails if "use TSC scaling" is 1 and TSC multiplier is 0.) > > To fix, expose TSC scaling to L1 only if kvm_has_tsc_control. > > Fixes: d041b5ea93352 ("KVM: nVMX: Enable nested TSC scaling") > Signed-off-by: Anirudh Rayabharam > --- > arch/x86/kvm/vmx/nested.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > index f5cb18e00e78..d773ddc6422b 100644 > --- a/arch/x86/kvm/vmx/nested.c > +++ b/arch/x86/kvm/vmx/nested.c > @@ -6656,6 +6656,9 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps) > msrs->secondary_ctls_low, > msrs->secondary_ctls_high); > > + if (!kvm_has_tsc_control) > + msrs->secondary_ctls_high &= ~SECONDARY_EXEC_TSC_SCALING; I would much rather we fix the root of the problem and not play whack-a-mole, e.g. all of the other controls that aren't supported by eVMCS have the same bug,. nested_vmx_setup_ctls_msrs() should use vmcs_config to get the base MSR values, not read the MSRs from hardware. And it's not just eVMCS, e.g. the manipulation of VM_{ENTRY,EXIT}_IA32_PERF_GLOBAL_CTRL for a CPU errata isn't handled either. > msrs->secondary_ctls_low = 0; > msrs->secondary_ctls_high &= > SECONDARY_EXEC_DESC | > @@ -6667,8 +6670,7 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps) > SECONDARY_EXEC_RDRAND_EXITING | > SECONDARY_EXEC_ENABLE_INVPCID | > SECONDARY_EXEC_RDSEED_EXITING | > - SECONDARY_EXEC_XSAVES | > - SECONDARY_EXEC_TSC_SCALING; > + SECONDARY_EXEC_XSAVES; > > /* > * We can emulate "VMCS shadowing," even if the hardware > -- > 2.34.1 >